Consumer, Producer, TopicPartition classes are now sub-classable #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
force-pushed
the
subclassable
branch
2 times, most recently
from
543d94f to
6935e4c
Compare
ewencp
reviewed
Nov 11, 2016
| @@ -55,7 +55,7 @@ static void Consumer_dealloc (Handle *self) { | |||
| if (self->rk) | |||
| rd_kafka_destroy(self->rk); | |||
|
|
|||
| Py_TYPE(self)->tp_free((PyObject *)self); | |||
| Py_TYPE(self)->tp_free((PyObject *)self); | |||
There was a problem hiding this comment.
We seem to be getting mixed tabs & spaces...
There was a problem hiding this comment.
The file originally has tabs for indention, which sucks but I probably coded it with the wrong .emacs file in place.
New changes use space for indent instead.
We can do a forklift untabify at some point.
|
@roopahc and @criccomini I'd like you to try this out before I merge it. |
|
@roopahc Thanks! |
edenhill
force-pushed
the
subclassable
branch
from
6935e4c to
864a935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.