From 08b04730c8f92b5fe25a8d47daed95db247d5304 Mon Sep 17 00:00:00 2001 From: mahajanadhitya Date: Tue, 10 Jan 2023 14:04:21 +0530 Subject: [PATCH] First iteration --- src/confluent_kafka/src/Consumer.c | 8 ++++---- src/confluent_kafka/src/confluent_kafka.c | 7 ++++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/confluent_kafka/src/Consumer.c b/src/confluent_kafka/src/Consumer.c index 66f5b7540..10729e9bd 100644 --- a/src/confluent_kafka/src/Consumer.c +++ b/src/confluent_kafka/src/Consumer.c @@ -970,8 +970,8 @@ static PyObject *Consumer_poll (Handle *self, PyObject *args, msgobj = Message_new0(self, rkm); #ifdef RD_KAFKA_V_HEADERS - // Have to detach headers outside Message_new0 because it declares the - // rk message as a const + /** Have to detach headers outside Message_new0 because it declares the + * rk message as a const */ rd_kafka_message_detach_headers(rkm, &((Message *)msgobj)->c_headers); #endif rd_kafka_message_destroy(rkm); @@ -1062,8 +1062,8 @@ static PyObject *Consumer_consume (Handle *self, PyObject *args, for (i = 0; i < n; i++) { PyObject *msgobj = Message_new0(self, rkmessages[i]); #ifdef RD_KAFKA_V_HEADERS - // Have to detach headers outside Message_new0 because it declares the - // rk message as a const + /** Have to detach headers outside Message_new0 because it declares the + * rk message as a const */ rd_kafka_message_detach_headers(rkmessages[i], &((Message *)msgobj)->c_headers); #endif PyList_SET_ITEM(msglist, i, msgobj); diff --git a/src/confluent_kafka/src/confluent_kafka.c b/src/confluent_kafka/src/confluent_kafka.c index bd57f2877..b68d4e3f1 100644 --- a/src/confluent_kafka/src/confluent_kafka.c +++ b/src/confluent_kafka/src/confluent_kafka.c @@ -1318,7 +1318,7 @@ PyObject *c_headers_to_py (rd_kafka_headers_t *headers) { while (!rd_kafka_header_get_all(headers, idx++, &header_key, &header_value, &header_value_size)) { - // Create one (key, value) tuple for each header + /* Create one (key, value) tuple for each header */ PyObject *header_tuple = PyTuple_New(2); PyTuple_SetItem(header_tuple, 0, cfl_PyUnistr(_FromString(header_key)) @@ -1660,7 +1660,8 @@ static void oauth_cb (rd_kafka_t *rk, const char *oauthbearer_config, sizeof(err_msg)); Py_DECREF(result); if (rd_extensions) { - for(int i = 0; i < rd_extensions_size; i++) { + int i; + for(i = 0; i < rd_extensions_size; i++) { free(rd_extensions[i]); } free(rd_extensions); @@ -2651,7 +2652,7 @@ static char *KafkaError_add_errs (PyObject *dict, const char *origdoc) { _PRINT("\n"); - return doc; // FIXME: leak + return doc; /* FIXME: leak */ }