Skip to content

Commit cf8d5a9

Browse files
gnu90 compatibility (#1512)
1 parent 1d1449f commit cf8d5a9

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/confluent_kafka/src/Consumer.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -970,8 +970,8 @@ static PyObject *Consumer_poll (Handle *self, PyObject *args,
970970

971971
msgobj = Message_new0(self, rkm);
972972
#ifdef RD_KAFKA_V_HEADERS
973-
// Have to detach headers outside Message_new0 because it declares the
974-
// rk message as a const
973+
/** Have to detach headers outside Message_new0 because it declares the
974+
* rk message as a const */
975975
rd_kafka_message_detach_headers(rkm, &((Message *)msgobj)->c_headers);
976976
#endif
977977
rd_kafka_message_destroy(rkm);
@@ -1062,8 +1062,8 @@ static PyObject *Consumer_consume (Handle *self, PyObject *args,
10621062
for (i = 0; i < n; i++) {
10631063
PyObject *msgobj = Message_new0(self, rkmessages[i]);
10641064
#ifdef RD_KAFKA_V_HEADERS
1065-
// Have to detach headers outside Message_new0 because it declares the
1066-
// rk message as a const
1065+
/** Have to detach headers outside Message_new0 because it declares the
1066+
* rk message as a const */
10671067
rd_kafka_message_detach_headers(rkmessages[i], &((Message *)msgobj)->c_headers);
10681068
#endif
10691069
PyList_SET_ITEM(msglist, i, msgobj);

src/confluent_kafka/src/confluent_kafka.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,7 @@ PyObject *c_headers_to_py (rd_kafka_headers_t *headers) {
13181318

13191319
while (!rd_kafka_header_get_all(headers, idx++,
13201320
&header_key, &header_value, &header_value_size)) {
1321-
// Create one (key, value) tuple for each header
1321+
/* Create one (key, value) tuple for each header */
13221322
PyObject *header_tuple = PyTuple_New(2);
13231323
PyTuple_SetItem(header_tuple, 0,
13241324
cfl_PyUnistr(_FromString(header_key))
@@ -1694,7 +1694,8 @@ static void oauth_cb (rd_kafka_t *rk, const char *oauthbearer_config,
16941694
sizeof(err_msg));
16951695
Py_DECREF(result);
16961696
if (rd_extensions) {
1697-
for(int i = 0; i < rd_extensions_size; i++) {
1697+
int i;
1698+
for(i = 0; i < rd_extensions_size; i++) {
16981699
free(rd_extensions[i]);
16991700
}
17001701
free(rd_extensions);
@@ -2739,7 +2740,7 @@ static char *KafkaError_add_errs (PyObject *dict, const char *origdoc) {
27392740

27402741
_PRINT("\n");
27412742

2742-
return doc; // FIXME: leak
2743+
return doc; /* FIXME: leak */
27432744
}
27442745

27452746

0 commit comments

Comments
 (0)