Skip to content

allow to set rpc.NamenodeConnection for the hdfs client #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
advincze opened this issue Dec 6, 2016 · 1 comment · Fixed by #63
Closed

allow to set rpc.NamenodeConnection for the hdfs client #62

advincze opened this issue Dec 6, 2016 · 1 comment · Fixed by #63

Comments

@advincze
Copy link
Contributor

advincze commented Dec 6, 2016

in my case I use a Socks proxy to access hdfs. I can already use the rpc.WrapNamenodeConnection to create an *rpc.NamenodeConnection but I cannot use it for the client.

This would work:

func NewForNamenode(namenode *rpc.NamenodeConnection) *Client {
	return &Client{namenode: namenode}
}

If if fits the project should I submit a PR ?

@colinmarc
Copy link
Owner

This is a good idea - I'd call it NewForConnection though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants