From 19000ad56e888d5e49bc5c2d89bfbcb7d449d681 Mon Sep 17 00:00:00 2001 From: Andrew Simmons Date: Mon, 27 Mar 2023 15:29:26 -0400 Subject: [PATCH 1/2] Replace call to self._clean_name with clean_name --- s3file/storages_optimized.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/s3file/storages_optimized.py b/s3file/storages_optimized.py index dbf39d9..e1a0597 100644 --- a/s3file/storages_optimized.py +++ b/s3file/storages_optimized.py @@ -1,4 +1,5 @@ from storages.backends.s3boto3 import S3Boto3Storage +from storages.utils import clean_name class S3OptimizedUploadStorage(S3Boto3Storage): @@ -16,7 +17,7 @@ class S3OptimizedUploadStorage(S3Boto3Storage): def _save(self, name, content): # Basically copy the implementation of _save of S3Boto3Storage # and replace the obj.upload_fileobj with a copy function - cleaned_name = self._clean_name(name) + cleaned_name = clean_name(name) name = self._normalize_name(cleaned_name) params = self._get_write_parameters(name, content) From c2036fed81f04da5daeaf1f24955c4bf503291c9 Mon Sep 17 00:00:00 2001 From: Andrew Simmons Date: Tue, 28 Mar 2023 09:49:34 -0400 Subject: [PATCH 2/2] Require django-storages>=1.6 clean_name utility function was first made available in version 1.6 --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 2ab4a6f..0e3a761 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -32,7 +32,7 @@ classifiers = [ requires-python = ">=3.9" dependencies = [ "django>=2.0", - "django-storages", + "django-storages>=1.6", "boto3", ]