From 12e4e658289c00468843ed1dcbc852e117302128 Mon Sep 17 00:00:00 2001 From: codersjj Date: Sun, 8 May 2022 09:43:53 +0800 Subject: [PATCH] refactor(event-bus): simplify the for loop in the off() method --- src/event-bus.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/event-bus.js b/src/event-bus.js index d2e8416..9eb4440 100644 --- a/src/event-bus.js +++ b/src/event-bus.js @@ -65,12 +65,10 @@ class HYEventBus { const handlers = this.eventBus[eventName] if (handlers && eventCallback) { - const newHandlers = [...handlers] - for (let i = 0; i < newHandlers.length; i++) { - const handler = newHandlers[i] + for (let i = handlers.length - 1; i >= 0; i--) { + const handler = handlers[i] if (handler.eventCallback === eventCallback) { - const index = handlers.indexOf(handler) - handlers.splice(index, 1) + handlers.splice(i, 1) } } }