Skip to content

Commit c598fdb

Browse files
committed
refactor: remove version from binaryPath
This removes the version from the binary path to ensure that the path always remains the same on OS's. This way, tools like Windows Firewall and macOS Firewill will only prompt for a security check on the first install but not subsequent installs.
1 parent 4f2dcd4 commit c598fdb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/storage.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export class Storage {
8080
const baseURI = vscode.Uri.parse(baseURL)
8181

8282
const buildInfo = await getBuildInfo()
83-
const binPath = this.binaryPath(buildInfo.version)
83+
const binPath = this.binaryPath()
8484
const exists = await fs
8585
.stat(binPath)
8686
.then(() => true)
@@ -260,10 +260,10 @@ export class Storage {
260260
}
261261
}
262262

263-
private binaryPath(version: string): string {
263+
private binaryPath(): string {
264264
const os = goos()
265265
const arch = goarch()
266-
let binPath = path.join(this.getBinaryCachePath(), `coder-${os}-${arch}-${version}`)
266+
let binPath = path.join(this.getBinaryCachePath(), `coder-${os}-${arch}`)
267267
if (os === "windows") {
268268
binPath += ".exe"
269269
}

0 commit comments

Comments
 (0)