vscode: Reconnect in the background up to 5 seconds #2381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
changed the title
I'll have to manually apply as they are not compatible with the latest VS Code after rebase anymore.
nhooyr
force-pushed
the
reconnect-6fa3
branch
from
324d49b to
dfaf274
Compare
Contributor
Author
|
Fixed the diff! |
Based on the previous commits by @mgmachado but simplified. I also changed the threshold to error after a single attempt as the connection has likely been borked and the user should be in the know if they couldn't reconnect after 5 seconds. Closes #1791
nhooyr
force-pushed
the
reconnect-6fa3
branch
from
dfaf274 to
c35d558
Compare
Contributor
|
LGTM. Much simpler! |
code-asher
approved these changes
Nov 30, 2020
jsjoeio
added a commit
that referenced
this pull request
Feb 25, 2021
As Asher pointed out, looks like it makes #2381 obsolete. Hope this all works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the previous commits by @mgmachado but simplified.
I also changed the threshold to error after a single attempt as the
connection has likely been borked and the user should be in the know if
they couldn't reconnect after 5 seconds.
Closes #1791