Skip to content

Commit a094400

Browse files
committed
refactor: delete buggy socket test
This test was really added to in get cover specific lines but it's buggy and only passes sometimes locally. I think it's okay to remove because: - it's an implementation detail (not user facing) - not preventing any specific regressions
1 parent 74330a1 commit a094400

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

test/unit/node/app.test.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -107,20 +107,6 @@ describe("createApp", () => {
107107
app.dispose()
108108
})
109109

110-
// TODO@jsjoeio - delete because this test it buggy?
111-
// or move into it's own describe block
112-
it("should change the file mode of a socket", async () => {
113-
const defaultArgs = await setDefaults({
114-
socket: tmpFilePath,
115-
"socket-mode": "777",
116-
})
117-
118-
const app = await createApp(defaultArgs)
119-
120-
expect((await promises.stat(tmpFilePath)).mode & 0o777).toBe(0o777)
121-
app.dispose()
122-
})
123-
124110
it("should create an https server if args.cert exists", async () => {
125111
const testCertificate = await generateCertificate("localhost")
126112
const cert = new OptionalString(testCertificate.cert)

0 commit comments

Comments
 (0)