PROXY-DOMAIN may be a subdomain + domain

ltomes · web-flow · commit 3dbff768e68f · 2022-08-04T11:26:17.000-05:00
This logging was confusing when a user passes a full &lt;subdomain&gt;.&lt;domain&gt; as proxy-domain, for instance when running code-server with cloudflare tunnels.
This is likely not the best fix. If preferred, I can do some work here to determine if the string is just a domain, or a subdomain+domain, and switch logging behavior based on that condition.
diff --git a/src/node/main.ts b/src/node/main.ts
@@ -153,7 +153,7 @@ export const runCodeServer = async (
 
   if (args["proxy-domain"].length > 0) {
     logger.info(`  - ${plural(args["proxy-domain"].length, "Proxying the following domain")}:`)
-    args["proxy-domain"].forEach((domain) => logger.info(`    - *.${domain}`))
+    args["proxy-domain"].forEach((domain) => logger.info(`    - ${domain}`))
   }
 
   if (args.link) {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ export const runCodeServer = async (`
`153`	`153`
`154`	`154`	`if (args["proxy-domain"].length > 0) {`
`155`	`155`	logger.info(` - ${plural(args["proxy-domain"].length, "Proxying the following domain")}:`)
`156`		- args["proxy-domain"].forEach((domain) => logger.info(` - *.${domain}`))
	`156`	+ args["proxy-domain"].forEach((domain) => logger.info(` - ${domain}`))
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`if (args.link) {`