From 0245860a9b0ce9486ef2739a1abb14b9da2a67a4 Mon Sep 17 00:00:00 2001 From: manirajyadav-1 Date: Sun, 5 Oct 2025 22:33:05 +0530 Subject: [PATCH 1/2] Move @PostMapping above Javadoc for updateEmailInfo method --- .../src/main/java/idealab/api/controller/MailController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Backend/src/main/java/idealab/api/controller/MailController.java b/Backend/src/main/java/idealab/api/controller/MailController.java index 6712d209..b4d61835 100644 --- a/Backend/src/main/java/idealab/api/controller/MailController.java +++ b/Backend/src/main/java/idealab/api/controller/MailController.java @@ -35,12 +35,12 @@ public ResponseEntity sendEmail(@RequestBody MailRequest mailRequest) { return new ResponseEntity<>(response, response.getHttpStatus()); } - @PostMapping("/info") /** * This updates the email and password associated with the application. * @param request * @return */ + @PostMapping("/info") public GenericResponse updateEmailInfo(@RequestBody UpdateEmailInfoRequest request) { String email = request.getEmail(); String pw = request.getPassword(); From 328fb5653f0b0fad1057c2e28cad52369b00ddb5 Mon Sep 17 00:00:00 2001 From: manirajyadav-1 Date: Sun, 5 Oct 2025 22:44:07 +0530 Subject: [PATCH 2/2] Add @Valid annotations for request validation and remove unused Principal parameter --- .../main/java/idealab/api/controller/PrintJobController.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Backend/src/main/java/idealab/api/controller/PrintJobController.java b/Backend/src/main/java/idealab/api/controller/PrintJobController.java index dc75b0fe..2b4760cc 100644 --- a/Backend/src/main/java/idealab/api/controller/PrintJobController.java +++ b/Backend/src/main/java/idealab/api/controller/PrintJobController.java @@ -49,7 +49,7 @@ public ResponseEntity printJobGetAll(@RequestParam(required = false) String s // TODO W.E. : add query param or boolean to model to accept mass upload (ignore 5 file max) @PostMapping - public ResponseEntity printJobNew(@ModelAttribute PrintJobNewRequest model, Principal principal) { + public ResponseEntity printJobNew(@Valid @ModelAttribute PrintJobNewRequest model, Principal principal) { DataResponse response = printJobOperations.newPrintJob(model, principal); return new ResponseEntity<>(response, response.getHttpStatus()); @@ -109,7 +109,7 @@ public ResponseEntity getDeletablePrintJobs() { //Don't include the field in the JSON if you dont want it updated @PutMapping("/{print-id}") - public ResponseEntity updatePrintJobProperties(@PathVariable("print-id") Integer printId, @RequestBody UpdatePrintJobPropertiesRequest request, Principal principal) { + public ResponseEntity updatePrintJobProperties(@PathVariable("print-id") Integer printId, @RequestBody UpdatePrintJobPropertiesRequest request) { DataResponse response = printJobOperations.updatePrintJobProps(printId, request); return new ResponseEntity<>(response, response.getHttpStatus()); }