Fix JS error #79
Merged
Fix JS error #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
requested review from
epeach,
fisher-alice,
jmkulwik,
maddiedierker,
mikeharv and
molly-moen
molly-moen
approved these changes
Aug 12, 2022
breville
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Aug 16, 2022
This gets us the fix in code-dot-org/maze#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new highest JS error on https://studio.code.org according to New Relic, over the past 7 days, is
Error: Cannot read property 'setAttribute' of nullin whichrecthere isnull. It mainly occurred over a 24 hour period which has now ended, but has been seen up to 6 months ago. There is no known repro, but the fix here should prevent more JS errors at least. A similar check forimgbeingnullhas also been added.