-
-
Notifications
You must be signed in to change notification settings - Fork 12
Improve documentation and examples #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f5e9505 to
0e6030c
Compare
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some remarks below
0e6030c to
0426973
Compare
|
Thanks for noticing this, should be changed right now @SimonFrings. ✨ |
0426973 to
52b3bad
Compare
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
52b3bad to
7872737
Compare
7872737 to
ea8be08
Compare
SimonFrings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ea8be08 to
4d7c1b3
Compare
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yadaiio Thanks for looking into this, changes LGTM! ![]()
|
This PR is going live! Release prep: #52. 🎉 |
Builds on top of #45, #30 and #29.
References: clue/reactphp-tar#20, clue/reactphp-redis#117, clue/reactphp-shell#20 and clue/reactphp-sqlite#43.