spring-cloud-connectors is deprecated

[dyroberts]

Usage of spring-cloud-connectors is deprecated in favour of java-cfenv.
https://github.com/pivotal-cf/java-cfenv
The module java-cfenv-boot presently includes support for mongodb, cassandra, redis, rabbitmq, and jdbc/datasource. The only thing I can see in java-buildpack-auto-reconfiguration's CloudServiceReconfigurationBeanFactoryPostProcessor that isn't directly supported by java-cfenv is javamail. If javamail support was added, it seems like a good chunk of the auto-reconfiguration could be dropped. WDYT?

[nebhale]

I've struggled with this because it's not a matter of what services are supported so much as what applications are supported. The big blocker to migrating is that java-cfenv (which I love dearly and had a hand in developing) does not support Spring applications, only Spring Boot applications. Losing this functionality is a serious regression (in the buildpack, not in java-cfenv) and I've not yet come to the conclusion that we can break those existing applications. Eventually we're going to have to as Cloud Connectors ages, but I'm not sure that day is today.

[dyroberts]

@nebhale Ok, understood! Maybe there's a half-way solution where we could detect boot and add java-cfenv rather than connectors? Barring that, we could detect java-cfenv and skip the connectors reconfiguration step? As of now, java-cfenv blows up if connectors is detected on the classpath; so users are forced to disable the java-buildpack-auto-reconfiguration altogether.

[nebhale]

Maybe something there. Let me chat with @markpollack about the best way to manage this.

[dyroberts]

Sounds good! FYI I've taken over maintenance of java-cfenv, ICYMI.

[dmikusa]

Closing. We have begun deprecating Spring Auto Reconfiguration from the buildpack.

cloudfoundry/java-buildpack#779 (comment)

[dev-praveen]

We have a spring boot application (version 1.5.9.RELEASE) that is deployed in PCF and works fine. We are trying to migrate it to java-cfenv-boot library by following the migration guide and removing the dependencies it suggests. However, we encounter a problem with the centralized configuration. The application fails to get the placeholder values from the Spring Cloud Config Server (bound to PCF).
This is the error we get: [OUT] Caused by: java.lang.IllegalArgumentException: Could not resolve placeholder ‘some.value’ in value “${some.value}”

removed
org.springframework.boot:spring-boot-starter-cloud-connectors
or
org.springframework.cloud:spring-cloud-core
org.springframework.cloud:spring-cloud-connectors-core
org.springframework.cloud:spring-cloud-cloudfoundry-connector
org.springframework.cloud:spring-cloud-spring-service-connector dependencies from pom file

added

io.pivotal.cfenv java-cfenv-boot 2.4.0

spring.profiles.active: dev,cloud
JBP_CONFIG_SPRING_AUTO_RECONFIGURATION: '{enabled: false}'

and we use java_buildpack_offline Please suggest to fix the issue.

[dyroberts]

@dev-praveen You should file a new issue. This one's been closed for going-on two years.