Fix tests against net/url error messages

See golang/go#29261. go 1.14 added quotes around error messages for net/url

Author: Shaan Sapra

httpclient/http_client_test.go

@@ -118,15 +118,15 @@ var _ = Describe("HTTPClient", func() {
 
 			_, err := httpClient.PostCustomized(url, []byte("post-request"), func(r *http.Request) {})
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("Post http://foo:<redacted>@10.10.0.0/path"))
+			Expect(err.Error()).To(ContainSubstring("http://foo:<redacted>@10.10.0.0/path"))
 		})
 
 		It("redacts passwords from error message for https calls", func() {
 			url := "https://foo:[email protected]/path"
 
 			_, err := httpClient.PostCustomized(url, []byte("post-request"), func(r *http.Request) {})
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("Post https://foo:<redacted>@10.10.0.0/path"))
+			Expect(err.Error()).To(ContainSubstring("https://foo:<redacted>@10.10.0.0/path"))
 		})
 
 		Describe("httpclient opts", func() {
@@ -378,15 +378,15 @@ var _ = Describe("HTTPClient", func() {
 
 			_, err := httpClient.PutCustomized(url, []byte("put-request"), func(r *http.Request) {})
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("Put http://foo:<redacted>@10.10.0.0/path"))
+			Expect(err.Error()).To(ContainSubstring("http://foo:<redacted>@10.10.0.0/path"))
 		})
 
 		It("redacts passwords from error message for https calls", func() {
 			url := "https://foo:[email protected]/path"
 
 			_, err := httpClient.PutCustomized(url, []byte("put-request"), func(r *http.Request) {})
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("Put https://foo:<redacted>@10.10.0.0/path"))
+			Expect(err.Error()).To(ContainSubstring("https://foo:<redacted>@10.10.0.0/path"))
 		})
 
 		Describe("httpclient opts", func() {
@@ -529,15 +529,15 @@ var _ = Describe("HTTPClient", func() {
 
 			_, err := httpClient.GetCustomized(url, func(r *http.Request) {})
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("Get http://foo:<redacted>@10.10.0.0/path"))
+			Expect(err.Error()).To(ContainSubstring("http://foo:<redacted>@10.10.0.0/path"))
 		})
 
 		It("redacts passwords from error message for https calls", func() {
 			url := "https://foo:[email protected]:8080/path"
 
 			_, err := httpClient.GetCustomized(url, func(r *http.Request) {})
 			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("Get https://foo:<redacted>@10.10.0.0:8080/path"))
+			Expect(err.Error()).To(ContainSubstring("https://foo:<redacted>@10.10.0.0:8080/path"))
 		})
 
 		Describe("httpclient opts", func() {