squash: valid types for ext values

Author: lholmquist

src/event/cloudevent.ts

@@ -2,7 +2,7 @@ import { v4 as uuidv4 } from "uuid";
 
 import { CloudEventV1, validateV1, CloudEventV1Attributes, CloudEventV1OptionalAttributes } from "./v1";
 import { CloudEventV03, validateV03, CloudEventV03Attributes, CloudEventV03OptionalAttributes } from "./v03";
-import { ValidationError, isBinary, asBase64 } from "./validation";
+import { ValidationError, isBinary, asBase64, isValidType } from "./validation";
 import CONSTANTS from "../constants";
 import { isString } from "util";
 
@@ -101,6 +101,13 @@ export class CloudEvent implements CloudEventV1, CloudEventV03 {
       if (!key.match(/^[a-z0-9]{1,20}$/)) {
         throw new ValidationError("invalid extension name");
       }
+
+      // Value should be spec complient
+      // https://github.com/cloudevents/spec/blob/master/spec.md#type-system
+      if (!isValidType(value)) {
+        throw new ValidationError("invalid extension value");
+      }
+
       this[key] = value;
     }
 

src/event/validation/is.ts

@@ -64,7 +64,7 @@ const asData = (data: unknown, contentType: string): string => {
   return isBinary(maybeJson) ? asBase64(maybeJson) : maybeJson;
 };
 
-const isValidType = (v: boolean | number | string | Date | Uint32Array): boolean =>
+const isValidType = (v: boolean | number | string | Date | Uint32Array | unknown): boolean =>
   isBoolean(v) || isInteger(v) || isString(v) || isDate(v) || isBinary(v);
 
 export {

test/integration/spec_1_tests.ts

@@ -87,12 +87,14 @@ describe("CloudEvents Spec v1.0", () => {
       expect(cloudevent.cloneWith({ extdate: myDate }).validate()).to.equal(true);
     });
 
-    // even though the spec doesn't allow object types for
-    // extensions, it could be JSON. And before a JS CE
-    // is transmitted across the wire, this value will be
-    // converted to JSON
-    it("should be ok when the type is an object", () => {
-      expect(cloudevent.cloneWith({ objectextension: { some: "object" } }).validate()).to.equal(true);
+    it("should fail when the type is an object", () => {
+      expect(() => {
+        cloudevent.cloneWith({ objectextension: { some: "object" } });
+      }).to.throw(ValidationError, "invalid extension value");
+    });
+
+    it("should be ok when the type is an string converted from an object", () => {
+      expect(cloudevent.cloneWith({ objectextension: JSON.stringify({ some: "object" }) }).validate()).to.equal(true);
     });
   });