feat: add new metrics #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
requested changes
Oct 6, 2023
Member
gabriel-samfira
left a comment
gabriel-samfira
left a comment
There was a problem hiding this comment.
This looks great! There is one small nit that happens in most collectors. You can replace // continue anyway with a simple return and get the same effect.
add info metrics about providers, enterprises, organizations, repositories and pools. Also expose most of the configurable pool information as metric like e.g. max Runners as garm_pool_max_runners Signed-off-by: Mario Constanti <[email protected]>
bavarianbidi
force-pushed
the
additional_metrics
branch
from
3cc6056 to
58e8b34
Compare
gabriel-samfira
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add info metrics about providers, enterprises, organizations, repositories and pools.
Also expose most of the configurable pool information as metric like e.g. max Runners as garm_pool_max_runners