Skip to content

Fix leiningen.clojure-lsp.binary/download-server? algorithm #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Fix leiningen.clojure-lsp.binary/download-server? algorithm #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324db22
Fix leiningen.clojure-lsp.binary/download-server? algorithm
acamargo Apr 4, 2025
06be736
Update CHANGELOG
acamargo Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Fix download server file predicate to handle file not found scenarios.

## 2.0.1

- Fix cached downloaded binary to check if downloaded version matches the current version in plugin.
Expand Down
4 changes: 2 additions & 2 deletions src/leiningen/clojure_lsp/binary.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@
@p))

(defn ^:private download-server? [server-path server-version-path version]
(or (not (.exists server-path))
(not= (slurp server-version-path) version)))
(not= version
(try (slurp server-version-path) (catch Exception _ :error-checking-local-version))))

(defn run! [args]
(let [server-path (server-path)
Expand Down