Make inf-clojure more intelligent about inf-clojure-program

[jethrokuan]

I think the inf-clojure command can be more intelligent about which command to when in a project file, since it uses the file to be aware of where the project root is.

https://github.com/clojure-emacs/inf-clojure/blob/master/inf-clojure.el#L324

This would be a huge convenience for those who use both boot and lein.

[bbatsov]

I'm not quite certain what exactly are you suggesting. More info would be welcome.

[jethrokuan]

Correct me if I'm wrong, but I believe right now, it calls inf-clojure-program, regardless of whether it is a lein or boot project. This means running inf-clojure would only work on either one, boot, or lein projects.

[bbatsov]

Yeah, that's what happens. You'd like to be asked which one to use (lein or boot)?

[jethrokuan]

Perhaps based on which kind of project file found, project.clj or
build.boot, run a different inf-clojure-program? There are edge cases where
they have both files, this may pose a problem.
On Feb 7, 2016 6:33 PM, "Bozhidar Batsov" notifications@github.com wrote:

Yeah, that's what happens. You'd like to be asked which one to use (lein
or boot)?

—
Reply to this email directly or view it on GitHub
#31 (comment)
.

[bbatsov]

I see - you'd like us to have different defcustoms for the different types of projects. Yeah, this can certainly be done. Btw, even now you can override the variable inf-clojure-program or a per-project basis using .dir-locals.el.

[jethrokuan]

Thanks, I didn't know that. I'm leaving this here just for consideration:
there's a point where I believe it'd be taking inf-clojure too far. I feel
that abstracting away this detail from the user is not one of them.

On Sun, Feb 7, 2016 at 8:11 PM, Bozhidar Batsov notifications@github.com
wrote:

I see - you'd like us to have different defcustoms for the different types
of projects. Yeah, this can certainly be done. Btw, even now you can
override the variable inf-clojure-program or a per-project basis using
.dir-locals.el.

—
Reply to this email directly or view it on GitHub
#31 (comment)
.

[bbatsov]

I've finally got to taking care of this. It's much more primitive that CIDER's project type handling, but it gets the job done and I really want to keep inf-clojure as simple as possible.

[jethrokuan]

perfect! Thanks for all the work. Regards, Jethro Kuan

…

On Mon, Mar 6, 2017 at 1:04 AM, Bozhidar Batsov ***@***.***> wrote: I've finally got to taking care of this. It's much more primitive that CIDER's project type handling, but it gets the job done and I really want to keep inf-clojure as simple as possible. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABlxkb32bgzB47ukYjq1NvXBluwjF6KIks5riusEgaJpZM4HKcxX> .