From 48fc6e40ebe457cc97a6d5114d221b59a2b87c00 Mon Sep 17 00:00:00 2001 From: yuhan0 Date: Thu, 26 Mar 2020 13:23:58 +0800 Subject: [PATCH 1/3] Move cider--debug-mode-map bindings into defvar --- cider-debug.el | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/cider-debug.el b/cider-debug.el index 15b124e0e..c25c99556 100644 --- a/cider-debug.el +++ b/cider-debug.el @@ -326,7 +326,14 @@ of `cider-interactive-eval' in debug sessions." (tool-bar-add-item "exit" #'cider-debug-mode-send-reply :quit :label "Quit") tool-bar-map)) -(defvar cider--debug-mode-map) +(defvar cider--debug-mode-map + (let ((map (make-sparse-keymap))) + ;; Bind the `:here` command to both h and H, because it behaves differently + ;; if invoked with an uppercase letter. + (define-key map "h" #'cider-debug-move-here) + (define-key map "H" #'cider-debug-move-here) + map) + "The active keymap during a debugging session.") (define-minor-mode cider--debug-mode "Mode active during debug sessions. @@ -382,11 +389,6 @@ In order to work properly, this mode must be activated by (when nrepl-ongoing-sync-request (ignore-errors (exit-recursive-edit))))) -;;; Bind the `:here` command to both h and H, because it behaves differently if -;;; invoked with an uppercase letter. -(define-key cider--debug-mode-map "h" #'cider-debug-move-here) -(define-key cider--debug-mode-map "H" #'cider-debug-move-here) - (defun cider--debug-remove-overlays (&optional buffer) "Remove CIDER debug overlays from BUFFER if variable `cider--debug-mode' is nil." (when (or (not buffer) (buffer-live-p buffer)) From 1d248c175774c34b6934ba9e1645aaf1f8d57fd1 Mon Sep 17 00:00:00 2001 From: yuhan0 Date: Thu, 26 Mar 2020 13:24:33 +0800 Subject: [PATCH 2/3] Bind "L" to toggle locals during debugging --- cider-debug.el | 1 + 1 file changed, 1 insertion(+) diff --git a/cider-debug.el b/cider-debug.el index c25c99556..a245eefcf 100644 --- a/cider-debug.el +++ b/cider-debug.el @@ -332,6 +332,7 @@ of `cider-interactive-eval' in debug sessions." ;; if invoked with an uppercase letter. (define-key map "h" #'cider-debug-move-here) (define-key map "H" #'cider-debug-move-here) + (define-key map "L" #'cider-debug-toggle-locals) map) "The active keymap during a debugging session.") From a3cceda5993f698039c734432cd9b93489b54f96 Mon Sep 17 00:00:00 2001 From: yuhan0 Date: Sat, 4 Apr 2020 17:02:02 +0800 Subject: [PATCH 3/3] Edit changelog and docs --- CHANGELOG.md | 1 + doc/modules/ROOT/pages/debugging/debugger.adoc | 3 +++ 2 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index eda8389d9..117ba209f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ ### New features +* [#2828](https://github.com/clojure-emacs/cider/pull/2828): Bind "L" to toggle display of locals during a debug session. * [#2800](https://github.com/clojure-emacs/cider/pull/2800): Add support for force-out debugger command. ### Changes diff --git a/doc/modules/ROOT/pages/debugging/debugger.adoc b/doc/modules/ROOT/pages/debugging/debugger.adoc index 8be0a720d..45a07ef3c 100644 --- a/doc/modules/ROOT/pages/debugging/debugger.adoc +++ b/doc/modules/ROOT/pages/debugging/debugger.adoc @@ -112,6 +112,9 @@ keys, although there are some differences. | kbd:[l] | Inspect local variables +| kbd:[L] +| Toggle display of local variables + | kbd:[j] | Inject a value into running code