From b264860f8a84a9901db29fc971d73f8f38404b07 Mon Sep 17 00:00:00 2001
From: Sam McCall <sam.mccall@gmail.com>
Date: Sat, 22 Oct 2022 02:36:45 +0200
Subject: [PATCH] Trigger signature help when accepting code completions, where
 appropriate.

As recommended in https://github.com/microsoft/vscode/issues/78806
This is an incomplete fix but better than nothing.
Also files https://github.com/microsoft/vscode/issues/164310 in case
VSCode can improve the behavior here.

fixes https://github.com/clangd/vscode-clangd/issues/390
---
 src/clangd-context.ts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/clangd-context.ts b/src/clangd-context.ts
index 3742d85c..a1f50116 100644
--- a/src/clangd-context.ts
+++ b/src/clangd-context.ts
@@ -122,6 +122,20 @@ export class ClangdContext implements vscode.Disposable {
             // notice until the behavior was in several releases, so we need
             // to override it on the client.
             item.commitCharacters = [];
+            // VSCode won't automatically trigger signature help when entering
+            // a placeholder, e.g. if the completion inserted brackets and
+            // placed the cursor inside them.
+            // https://github.com/microsoft/vscode/issues/164310
+            // They say a plugin should trigger this, but LSP has no mechanism.
+            // https://github.com/microsoft/language-server-protocol/issues/274
+            // (This workaround is incomplete, and only helps the first param).
+            if (item.insertText instanceof vscode.SnippetString &&
+                !item.command &&
+                item.insertText.value.match(/[([{<,] ?\$\{?[01]\D/))
+              item.command = {
+                title: 'Signature help',
+                command: 'editor.action.triggerParameterHints'
+              };
             return item;
           })
           return new vscode.CompletionList(items, /*isIncomplete=*/ true);