rn-tester > Use code-generated Turbo Module name constants (facebook#38297)

christophpurrer · facebook-github-bot · commit 688e18c47fce · 2023-07-11T14:24:51.000-07:00
Summary: Pull Request resolved: facebook#38297 Continuation of facebook#38295 Changelog: [Internal] [Changed] - Use code-generated Turbo Module name constants Reviewed By: shwanton Differential Revision: D47376344 fbshipit-source-id: 83d38df83789bdab17a3c772c7aad6db6891859e
diff --git a/packages/rn-tester/RNTester/AppDelegate.mm b/packages/rn-tester/RNTester/AppDelegate.mm
@@ -71,7 +71,7 @@ - (void)loadSourceForBridge:(RCTBridge *)bridge
     return std::make_shared<facebook::react::SampleTurboCxxModule>(jsInvoker);
   }
 #ifdef RCT_NEW_ARCH_ENABLED
-  if (name == std::string([@"NativeCxxModuleExampleCxx" UTF8String])) {
+  if (name == facebook::react::NativeCxxModuleExample::kModuleName) {
     return std::make_shared<facebook::react::NativeCxxModuleExample>(jsInvoker);
   }
 #endif
diff --git a/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp b/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp
@@ -33,7 +33,7 @@ void registerComponents(
 std::shared_ptr<TurboModule> cxxModuleProvider(
     const std::string &name,
     const std::shared_ptr<CallInvoker> &jsInvoker) {
-  if (name == "NativeCxxModuleExampleCxx") {
+  if (name == NativeCxxModuleExample::kModuleName) {
     return std::make_shared<NativeCxxModuleExample>(jsInvoker);
   }
   return nullptr;

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ - (void)loadSourceForBridge:(RCTBridge *)bridge`
`71`	`71`	`return std::make_shared<facebook::react::SampleTurboCxxModule>(jsInvoker);`
`72`	`72`	`}`
`73`	`73`	`#ifdef RCT_NEW_ARCH_ENABLED`
`74`		`- if (name == std::string([@"NativeCxxModuleExampleCxx" UTF8String])) {`
	`74`	`+ if (name == facebook::react::NativeCxxModuleExample::kModuleName) {`
`75`	`75`	`return std::make_shared<facebook::react::NativeCxxModuleExample>(jsInvoker);`
`76`	`76`	`}`
`77`	`77`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ void registerComponents(`
`33`	`33`	`std::shared_ptr<TurboModule> cxxModuleProvider(`
`34`	`34`	`const std::string &name,`
`35`	`35`	`const std::shared_ptr<CallInvoker> &jsInvoker) {`
`36`		`- if (name == "NativeCxxModuleExampleCxx") {`
	`36`	`+ if (name == NativeCxxModuleExample::kModuleName) {`
`37`	`37`	`return std::make_shared<NativeCxxModuleExample>(jsInvoker);`
`38`	`38`	`}`
`39`	`39`	`return nullptr;`