Skip to content

Commit b855b48

Browse files
committed
action_sheet test: Remove unnecessary binding setup
These calls only need to happen once, at the top of `main`: zulip#410 (comment)
1 parent e7a7bef commit b855b48

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/widgets/action_sheet_test.dart

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
6969

7070
void main() {
7171
TestZulipBinding.ensureInitialized();
72+
TestWidgetsFlutterBinding.ensureInitialized();
7273

7374
void prepareRawContentResponseSuccess(PerAccountStore store, {
7475
required Message message,
@@ -91,12 +92,7 @@ void main() {
9192
}
9293

9394
group('ShareButton', () {
94-
// Tests should call setupMockSharePlus.
95-
setUp(() async {
96-
TestZulipBinding.ensureInitialized();
97-
TestWidgetsFlutterBinding.ensureInitialized();
98-
});
99-
95+
// Tests should call this.
10096
MockSharePlus setupMockSharePlus() {
10197
final mock = MockSharePlus();
10298
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler(
@@ -304,8 +300,6 @@ void main() {
304300

305301
group('CopyButton', () {
306302
setUp(() async {
307-
TestZulipBinding.ensureInitialized();
308-
TestWidgetsFlutterBinding.ensureInitialized();
309303
TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler(
310304
SystemChannels.platform,
311305
MockClipboard().handleMethodCall,

0 commit comments

Comments
 (0)