dialog: Sweep through error dialogs, giving message final punctuation

Author: chrisbobbe

assets/l10n/app_en.arb

@@ -168,7 +168,7 @@
       "server": {"type": "String", "example": "https://example.com"}
     }
   },
-  "errorCouldNotFetchMessageSource": "Could not fetch message source",
+  "errorCouldNotFetchMessageSource": "Could not fetch message source.",
   "@errorCouldNotFetchMessageSource": {
     "description": "Error message when the source of a message could not be fetched."
   },
@@ -554,7 +554,7 @@
       "url": {"type": "String", "example": "http://chat.example.com/"}
     }
   },
-  "errorInvalidResponse": "The server sent an invalid response",
+  "errorInvalidResponse": "The server sent an invalid response.",
   "@errorInvalidResponse": {
     "description": "Error message when an API call returned an invalid response."
   },
@@ -584,7 +584,7 @@
       "httpStatus": {"type": "int", "example": "500"}
     }
   },
-  "errorVideoPlayerFailed": "Unable to play the video",
+  "errorVideoPlayerFailed": "Unable to play the video.",
   "@errorVideoPlayerFailed": {
     "description": "Error message when a video fails to play."
   },

lib/generated/l10n/zulip_localizations.dart

@@ -359,7 +359,7 @@ abstract class ZulipLocalizations {
   /// Error message when the source of a message could not be fetched.
   ///
   /// In en, this message translates to:
-  /// **'Could not fetch message source'**
+  /// **'Could not fetch message source.'**
   String get errorCouldNotFetchMessageSource;
 
   /// Error message when copying the text of a message to the user's system clipboard failed.
@@ -857,7 +857,7 @@ abstract class ZulipLocalizations {
   /// Error message when an API call returned an invalid response.
   ///
   /// In en, this message translates to:
-  /// **'The server sent an invalid response'**
+  /// **'The server sent an invalid response.'**
   String get errorInvalidResponse;
 
   /// Error message when a network request fails.
@@ -887,7 +887,7 @@ abstract class ZulipLocalizations {
   /// Error message when a video fails to play.
   ///
   /// In en, this message translates to:
-  /// **'Unable to play the video'**
+  /// **'Unable to play the video.'**
   String get errorVideoPlayerFailed;
 
   /// Error message when URL is empty

lib/generated/l10n/zulip_localizations_ar.dart

@@ -141,7 +141,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
 
   @override
   String get errorCouldNotFetchMessageSource =>
-      'Could not fetch message source';
+      'Could not fetch message source.';
 
   @override
   String get errorCopyingFailed => 'Copying failed';
@@ -454,7 +454,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   }
 
   @override
-  String get errorInvalidResponse => 'The server sent an invalid response';
+  String get errorInvalidResponse => 'The server sent an invalid response.';
 
   @override
   String get errorNetworkRequestFailed => 'Network request failed';
@@ -475,7 +475,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   }
 
   @override
-  String get errorVideoPlayerFailed => 'Unable to play the video';
+  String get errorVideoPlayerFailed => 'Unable to play the video.';
 
   @override
   String get serverUrlValidationErrorEmpty => 'Please enter a URL.';

lib/generated/l10n/zulip_localizations_en.dart

@@ -141,7 +141,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
 
   @override
   String get errorCouldNotFetchMessageSource =>
-      'Could not fetch message source';
+      'Could not fetch message source.';
 
   @override
   String get errorCopyingFailed => 'Copying failed';
@@ -454,7 +454,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   }
 
   @override
-  String get errorInvalidResponse => 'The server sent an invalid response';
+  String get errorInvalidResponse => 'The server sent an invalid response.';
 
   @override
   String get errorNetworkRequestFailed => 'Network request failed';
@@ -475,7 +475,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   }
 
   @override
-  String get errorVideoPlayerFailed => 'Unable to play the video';
+  String get errorVideoPlayerFailed => 'Unable to play the video.';
 
   @override
   String get serverUrlValidationErrorEmpty => 'Please enter a URL.';

lib/generated/l10n/zulip_localizations_ja.dart

@@ -141,7 +141,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
 
   @override
   String get errorCouldNotFetchMessageSource =>
-      'Could not fetch message source';
+      'Could not fetch message source.';
 
   @override
   String get errorCopyingFailed => 'Copying failed';
@@ -454,7 +454,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   }
 
   @override
-  String get errorInvalidResponse => 'The server sent an invalid response';
+  String get errorInvalidResponse => 'The server sent an invalid response.';
 
   @override
   String get errorNetworkRequestFailed => 'Network request failed';
@@ -475,7 +475,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   }
 
   @override
-  String get errorVideoPlayerFailed => 'Unable to play the video';
+  String get errorVideoPlayerFailed => 'Unable to play the video.';
 
   @override
   String get serverUrlValidationErrorEmpty => 'Please enter a URL.';

lib/generated/l10n/zulip_localizations_nb.dart

@@ -141,7 +141,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
 
   @override
   String get errorCouldNotFetchMessageSource =>
-      'Could not fetch message source';
+      'Could not fetch message source.';
 
   @override
   String get errorCopyingFailed => 'Copying failed';
@@ -454,7 +454,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   }
 
   @override
-  String get errorInvalidResponse => 'The server sent an invalid response';
+  String get errorInvalidResponse => 'The server sent an invalid response.';
 
   @override
   String get errorNetworkRequestFailed => 'Network request failed';
@@ -475,7 +475,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   }
 
   @override
-  String get errorVideoPlayerFailed => 'Unable to play the video';
+  String get errorVideoPlayerFailed => 'Unable to play the video.';
 
   @override
   String get serverUrlValidationErrorEmpty => 'Please enter a URL.';

lib/log.dart

@@ -80,6 +80,7 @@ typedef ReportErrorCallback = void Function(
 ///
 /// If `details` is non-null, the [SnackBar] will contain a button that would
 /// open a dialog containing the error details.
+/// Prose in `details` should have final punctuation.
 // This gets set in [ZulipApp].  We need this indirection to keep `lib/log.dart`
 // from importing widget code, because the file is a dependency for the rest of
 // the app.
@@ -91,6 +92,8 @@ ReportErrorCancellablyCallback reportErrorToUserBriefly = defaultReportErrorToUs
 /// as the body.  If called before the app's widget tree is ready
 /// (see [ZulipApp.ready]), then we give up on showing the message to the user,
 /// and just log the message to the console.
+///
+/// Prose in `message` should have final punctuation.
 // This gets set in [ZulipApp].  We need this indirection to keep `lib/log.dart`
 // from importing widget code, because the file is a dependency for the rest of
 // the app.

lib/widgets/dialog.dart

@@ -49,6 +49,9 @@ class DialogStatus<T> {
 ///
 /// The [DialogStatus.result] field of the return value can be used
 /// for waiting for the dialog to be closed.
+///
+/// Prose in [message] should have final punctuation:
+///   https://github.com/zulip/zulip-flutter/pull/1498#issuecomment-2853578577
 // This API is inspired by [ScaffoldManager.showSnackBar].  We wrap
 // [showDialog]'s return value, a [Future], inside [DialogStatus]
 // whose documentation can be accessed.  This helps avoid confusion when