Add manual purchase finish #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lunarraid Why do you close this PR? I use your PR well. Is there any problem on this PR? |
Author
|
This PR was made in error. I meant to pull the change into the master branch of my fork only, as this change breaks compatibility with the main repo. |
|
@lunarraid I understand. I've used this PR to my fork repo. Thanks for sharing your useful code. |
|
@lunarraid this is extremely useful and necessary for the library. Do you think you could be convinced to merge your functionality into the lib? |
Author
|
I have no problem with re-opening this if the maintainer is cool with the breaking changes. |
Owner
|
I'm fine with making a breaking change. Refer the thread here: #124 (comment) |
Author
|
#135 has been opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.