Fix crash in ManifestBrowser when only hidden manifests are present (BugFix) #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
==========================================
+ Coverage 51.13% 51.15% +0.02%
==========================================
Files 386 386
Lines 41603 41602 -1
Branches 7730 7727 -3
==========================================
+ Hits 21272 21280 +8
+ Misses 19569 19560 -9
Partials 762 762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gntzio
force-pushed
the
manifest-edit-crash-hidden-only
branch
from
c835e9b to
433be4f
Compare
Hook25
requested changes
Jul 7, 2025
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
My main comment here is: dont duplicate the code to get manifests by visibility.
Hook25
added
the
waiting-for-changes
gntzio
removed
the
waiting-for-changes
Hook25
added
the
waiting-for-changes
Hook25
previously approved these changes
Jul 21, 2025
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
+1, thanks
please rebase your PR on main
…manifests are hidde.
…uce code duplication.
…save_manifest in RemoteController, make tests more readable.
gntzio
force-pushed
the
manifest-edit-crash-hidden-only
branch
from
a014835 to
0f9b3b8
Compare
gntzio
removed
the
waiting-for-changes
Collaborator
Author
@Hook25, Done. |
Hook25
approved these changes
Jul 24, 2025
stanley31huang
pushed a commit
that referenced
this pull request
Aug 14, 2025
…BugFix) (#1996) * Fix crash in ManifestBrowser when only hidden manifests are present. * The manifest screen is not shown even in interactive mode if all the manifests are hidde. * Comply the code with Python 3.5. * Adjust tests by putting them in a proper test classes + comments. Reduce code duplication. * Rename ManifestBrowser.get_flattened_values, apply the same fix for _save_manifest in RemoteController, make tests more readable.
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
…BugFix) (#1996) * Fix crash in ManifestBrowser when only hidden manifests are present. * The manifest screen is not shown even in interactive mode if all the manifests are hidde. * Comply the code with Python 3.5. * Adjust tests by putting them in a proper test classes + comments. Reduce code duplication. * Rename ManifestBrowser.get_flattened_values, apply the same fix for _save_manifest in RemoteController, make tests more readable.
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
…BugFix) (#1996) * Fix crash in ManifestBrowser when only hidden manifests are present. * The manifest screen is not shown even in interactive mode if all the manifests are hidde. * Comply the code with Python 3.5. * Adjust tests by putting them in a proper test classes + comments. Reduce code duplication. * Rename ManifestBrowser.get_flattened_values, apply the same fix for _save_manifest in RemoteController, make tests more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ManifestBrowser.unhandled_inputis extracted intohandle_submit_key&handle_focused_question_input.Launcher._save_manifesttoManifestBrowser- Launcher should work with manifests only through ManifestBrowser. The same done inRemoteController.Launcher&RemoteControllertests with_save_manifesttests.Resolved issues
Fixes: CHECKBOX-1963
Documentation
N/A
Tests
The fix was tested manually (only Launcher) + covered by unit tests (see the Description).