Remote assistant refactoring (new) (#2057)

* Full refactoring backported to remote_assistant.py

* Backport controller refactoring

Forgotten removed api

* Fix unit tests by renaming apis and changing whats_up response

* Refactored allowed_when and _state -> state

Decorator was moved to top level of the module, state now has a
non-private property (that logs transitions) and was changed accordingly

Minor fix: use .state and not ._state in decorator

* Renamed resume_session to prepare_resume_session

Minor: forgotten 2 state comparison to str instead of new enum

* Missing bootstrap_and_continue

* Remove outdated resume machanism

* Check that all states have a connection_strategy

* Support optional parameters of interaction

* Include test plan in session metadata

* Move functions, rename functions that continue with _continue

* Default value of resume_by_id should be empty dict

* Propagate prepare_resume_session

* Also update name in the test

* Don't finalize the session until resume is decided

This removes session finalization in all branches. It was added because
the start_new_sesison function starts a new session, so it fails on the
second iteration. The correct solution to this was not to spam finalize
everywhere but to split that function up into start and select_test_plan

(thanks me, I know you did this to me)

* Port renames and new _continue process to tests

* Also fix local changes to subcommands

* Test test plan selection function

Minor: use new continue session function

* Disable fail-fast

* Update checkbox-ng/checkbox_ng/launcher/controller.py

Co-authored-by: Fernando Bravo <[email protected]>

---------

Co-authored-by: Fernando Bravo <[email protected]>

Author: Hook25

.github/workflows/tox-checkbox.yaml

@@ -3,7 +3,6 @@ permissions:
   contents: read
 on:
   push:
-    branches: [ main ]
     paths:
       - checkbox-ng/**
       - checkbox-support/**
@@ -18,7 +17,6 @@ on:
       - providers/iiotg/**
       - .github/workflows/tox-checkbox.yaml
   pull_request:
-    branches: [ main ]
     paths:
       - checkbox-ng/**
       - checkbox-support/**
@@ -95,6 +93,7 @@ jobs:
   tox_test_checkbox_component:
     needs: get_path_matrix
     strategy:
+      fail-fast: false
       matrix:
         path_flag: ${{ fromJson(needs.get_path_matrix.outputs.path_flag) }}
         python: ["3.5", "3.6", "3.8", "3.10", "3.12"]

checkbox-ng/checkbox_ng/launcher/agent.py

@@ -146,19 +146,6 @@ def invoked(self, ctx):
             lambda x: None
         )
 
-        # the agent is meant to be run only as a service,
-        # and we always resume if the session was automated,
-        # so we don't need to encode check whether we should resume
-
-        sessions = list(ctx.sa.get_resumable_sessions())
-        if sessions:
-            # the sessions are ordered by time, so the first one is the most
-            # recent one
-            if is_the_session_noninteractive(sessions[0]):
-                SessionAssistantAgent.session_assistant.resume_by_id(
-                    sessions[0].id
-                )
-
         self._server = ThreadedServer(
             SessionAssistantAgent,
             port=agent_port,
@@ -184,25 +171,6 @@ def register_arguments(self, parser):
         )
 
 
-def is_the_session_noninteractive(
-    resumable_session: "ResumeCandidate",
-) -> bool:
-    """
-    Check if given session is non-interactive.
-
-    To determine that we need to take the original launcher that had been used
-    when the session was started, recreate it as a proper Launcher object, and
-    check if it's in fact non-interactive.
-    """
-    # app blob is a bytes string with a utf-8 encoded json
-    # let's decode it and parse it as json
-    app_blob = json.loads(resumable_session.metadata.app_blob.decode("utf-8"))
-    launcher = Configuration.from_text(
-        app_blob.get("launcher", ""), "resumed session"
-    )
-    return launcher.sections["ui"].get("type") == "silent"
-
-
 def exit_if_port_unavailable(port: int) -> None:
     """
     Check if the port is available and exit if it's not.