Use cadence-idl repo IDL storage #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delete thrift dir
meiliang86
approved these changes
Jan 16, 2020
| import com.uber.cadence.WorkflowExecutionFilter; | ||
| import com.uber.cadence.WorkflowExecutionInfo; | ||
| import com.uber.cadence.WorkflowIdReusePolicy; | ||
| import com.uber.cadence.*; |
| import com.uber.cadence.UpdateDomainResponse; | ||
| import com.uber.cadence.WorkflowExecution; | ||
| import com.uber.cadence.WorkflowExecutionAlreadyStartedError; | ||
| import com.uber.cadence.*; |
Contributor
There was a problem hiding this comment.
Please consider removing the start import and import all classes independently
Contributor
There was a problem hiding this comment.
See also the following classes:
- src/main/java/com/uber/cadence/internal/sync/TestWorkflowEnvironmentInternal.java
- src/main/java/com/uber/cadence/internal/testservice/TestWorkflowService.java
Contributor
|
To add to this issue @meiliang86: wouldn't it be of more convenience to automatically update the submodule and if not initialized yet, initialize it during the building phase? |
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.