fix: allow .git directory on parent directory #225
Conversation
roman
force-pushed
the
rgonzalez/fix/allow-pre-commit-on-subdir
branch
from
d9c9f63 to
c67006f
Compare
roman
force-pushed
the
rgonzalez/fix/allow-pre-commit-on-subdir
branch
from
c67006f to
ee2300b
Compare
|
Hey @domenkozar, this has been here for a while, and recently started working due to the dependency being merged to nixpkgs, would you consider adding it? |
|
@roman could you backport it to 22.11? We also want to support the stable version in pre-commit-hooks.nix |
modules/pre-commit.nix
Outdated
| @@ -366,7 +366,7 @@ in | |||
| if ! type -t git >/dev/null; then | |||
| # This happens in pure shells, including lorri | |||
| echo 1>&2 "WARNING: pre-commit-hooks.nix: git command not found; skipping installation." | |||
| elif [[ ! -e .git ]]; then | |||
| elif ! ${pkgs.locate-dominating-file}/bin/locate-dominating-file .git >/dev/null; then | |||
There was a problem hiding this comment.
This should probably be written with git rev-parse --git-dir, unless there is a specific reason to avoid the git binary for this lookup.
There was a problem hiding this comment.
I was trying to understand the nix runtime dependencies of this generated script, but I'm unable to find any via nix-store --query.
We must have the assumption that git is installed already, so I don't think avoiding depending on it here gains us anything.
All this to say, I agree @imsofi, let me change that to the git command.
Currently, the check to validate pre-commit-hooks are getting installed on a git repository only consider the `.git` directory, if the pre-commit-hooks config lives in another path that is not the root of the repository, pre-commit-hooks won't install a script. This change allows flake.nix files in sub-directories to have the pre-commit-hooks configuration. This is specially common in monorepos.
roman
force-pushed
the
rgonzalez/fix/allow-pre-commit-on-subdir
branch
from
ee2300b to
3973f37
Compare
Currently, the check to validate pre-commit-hooks is getting installed on a git repository only considers the
.gitdirectory if the pre-commit-hooks config is at the root path; if the pre-commit-hooks config lives in another path that is not the root of the repository, pre-commit-hooks won't install a script.This change allows
flake.nixfiles in sub-directories to have the pre-commit-hooks configuration. This is especially common in monorepos.Note, this change requires a PR on
nixpkgsto be merged before this code works.resolves #224