Skip to content

Commit c02d426

Browse files
committed
convert helpers/init_host into a pure function
1 parent 2052370 commit c02d426

File tree

7 files changed

+16
-24
lines changed

7 files changed

+16
-24
lines changed

libiocage/lib/Distribution.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class DistributionGenerator:
5050
def __init__(self, host, zfs=None, logger=None):
5151
self.logger = libiocage.lib.helpers.init_logger(logger)
5252
self.zfs = libiocage.lib.helpers.init_zfs(zfs)
53-
libiocage.lib.helpers.init_host(self, host)
53+
self.host = libiocage.lib.helpers.init_host(host, logger=self.logger)
5454

5555
self.available_releases = None
5656

libiocage/lib/Jail.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ def __init__(self, data={}, zfs=None, host=None, logger=None, new=False):
106106

107107
self.logger = libiocage.lib.helpers.init_logger(logger)
108108
self.zfs = libiocage.lib.helpers.init_zfs(zfs)
109-
110-
libiocage.lib.helpers.init_host(self, host)
109+
self.host = libiocage.lib.helpers.init_host(host, logger=self.logger)
111110

112111
if isinstance(data, str):
113112
data = {
@@ -942,8 +941,6 @@ def __dir__(self):
942941

943942
class Jail(JailGenerator):
944943

945-
_class_host = libiocage.lib.Host.HostGenerator
946-
947944
def start(self, *args, **kwargs):
948945
return list(JailGenerator.start(self, *args, **kwargs))
949946

libiocage/lib/Jails.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def __init__(self,
4747
zfs=None):
4848

4949
self.logger = libiocage.lib.helpers.init_logger(logger)
50-
libiocage.lib.helpers.init_host(self, host)
50+
self.host = libiocage.lib.helpers.init_host(host, logger=self.logger)
5151

5252
# this could be wrong..er.. now?:
5353
self.zfs = libiocage.lib.helpers.init_zfs(zfs)

libiocage/lib/Prompts.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727

2828
class Prompts:
2929
def __init__(self, host=None, logger=None):
30-
self.logger = logger
31-
libiocage.lib.helpers.init_host(self, host)
30+
self.logger = libiocage.lib.helpers.init_logger(logger)
31+
self.host = libiocage.lib.helpers.init_host(host, logger=self.logger)
3232

3333
def release(self):
3434
default = None

libiocage/lib/Release.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def __init__(self, name=None,
5858

5959
self.logger = libiocage.lib.helpers.init_logger(logger)
6060
self.zfs = libiocage.lib.helpers.init_zfs(zfs)
61-
libiocage.lib.helpers.init_host(self, host)
61+
self.host = libiocage.lib.helpers.init_host(host, logger=self.logger)
6262

6363
if not libiocage.lib.helpers.validate_name(name):
6464
raise NameError(f"Invalid 'name' for Release: '{name}'")

libiocage/lib/Releases.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727

2828
class Releases:
2929
def __init__(self, host=None, zfs=None, logger=None):
30-
libiocage.lib.helpers.init_host(self, host)
31-
self.logger = logger
32-
self.zfs = zfs
30+
self.logger = libiocage.lib.helpers.init_logger(logger)
31+
self.zfs = libiocage.lib.helpers.init_zfs(zfs)
32+
self.host = libiocage.lib.helpers.init_host(host, logger=self.logger)
3333

3434
@property
3535
def dataset(self):

libiocage/lib/helpers.py

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,14 @@ def get_zfs():
4242
return libzfs.ZFS(history=True, history_prefix="<iocage>")
4343

4444

45-
def init_host(self, host=None):
45+
def init_host(
46+
host: 'libiocage.lib.Host.Host'=None,
47+
logger: 'libiocage.lib.Logger.Logger'=None
48+
) -> 'libiocage.lib.Host.HostGenerator':
4649
if host:
47-
self.host = host
48-
else:
49-
try:
50-
logger = self.logger
51-
except:
52-
logger = None
53-
54-
try:
55-
self.host = self._class_host(logger=logger)
56-
except:
57-
self.host = libiocage.lib.Host.HostGenerator(logger=logger)
50+
return host
51+
52+
return libiocage.lib.Host.HostGenerator(logger=logger)
5853

5954

6055
def init_datasets(self, datasets=None):

0 commit comments

Comments
 (0)