Skip to content

Commit 35b76a4

Browse files
igalicgronke
authored andcommitted
use None as default for arrays
a non-None default causes the parameters to be pass-by-reference, and hence mutable! We don't generally want that. This partially(??) addresses #38
1 parent 8ccc06c commit 35b76a4

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

libiocage/lib/JailConfigAddresses.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,10 @@ def read(self, config_line):
6161
if self.skip_on_error is False:
6262
exit(1)
6363

64-
def add(self, nic, addresses=[], notify=True):
64+
def add(self, nic, addresses=None, notify=True):
65+
66+
if addresses is None or addresses == [] or addresses == "":
67+
return
6568

6669
if isinstance(addresses, str):
6770
addresses = [addresses]

libiocage/lib/JailConfigInterfaces.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@ def read(self, value):
3333
jail_if, bridge_if = nic_pair.split(":", maxsplit=1)
3434
self.add(jail_if, bridge_if, notify=False)
3535

36-
def add(self, jail_if, bridges=[], notify=True):
36+
def add(self, jail_if, bridges=None, notify=True):
37+
38+
if bridges is None or bridges == [] or bridges == "":
39+
return
3740

3841
if isinstance(bridges, str):
3942
bridges = [bridges]

0 commit comments

Comments
 (0)