Use the configured proxy host and port for the download

#14

Author: mohlendo

lib/HttpsProxyAgent.js

@@ -0,0 +1,123 @@
+var util = require('util'),
+  https = require('https'),
+  http = require('http'),
+  lls = require('tls');
+
+function HttpsProxyAgent(options){
+  https.Agent.call(this, options);
+
+  this.proxyHost = options.proxyHost;
+  this.proxyPort = options.proxyPort;
+
+  this.createConnection = function (opts, callback){
+    // do a CONNECT request
+    var req = http.request({
+      host: options.proxyHost,
+      port: options.proxyPort,
+      method: 'CONNECT',
+      path: opts.host + ':' + opts.port,
+      headers: {
+        host: opts.host
+      }
+    });
+
+    req.on('connect', function (res, socket, head){
+      var cts = lls.connect({
+        host: opts.host,
+        socket: socket
+      }, function () {
+        callback(false, cts);
+      });
+    });
+
+    req.on('error', function (err) {
+      callback(err, null);
+    });
+
+    req.end();
+  }
+}
+
+util.inherits(HttpsProxyAgent, https.Agent);
+
+// Almost verbatim copy of http.Agent.addRequest
+HttpsProxyAgent.prototype.addRequest = function (req, options){
+  var name = options.host + ':' + options.port;
+  if(options.path) name += ':' + options.path;
+
+  if(!this.sockets[name]) this.sockets[name] = [];
+
+  if(this.sockets[name].length < this.maxSockets){
+    // if we are under maxSockets create a new one.
+    this.createSocket(name, options.host, options.port, options.path, req, function (socket){
+      req.onSocket(socket);
+    });
+  }else{
+    // we are over limit so we'll add it to the queue.
+    if(!this.requests[name])
+      this.requests[name] = [];
+    this.requests[name].push(req);
+  }
+};
+
+// Almost verbatim copy of http.Agent.createSocket
+HttpsProxyAgent.prototype.createSocket = function (name, host, port, localAddress, req, callback){
+  var self = this;
+  var options = util._extend({}, self.options);
+  options.port = port;
+  options.host = host;
+  options.localAddress = localAddress;
+
+  options.servername = host;
+  if(req){
+    var hostHeader = req.getHeader('host');
+    if(hostHeader)
+      options.servername = hostHeader.replace(/:.*$/, '');
+  }
+
+  self.createConnection(options, function (err, s) {
+    if(err) {
+      err.message += ' while connecting to HTTP(S) proxy server ' + self.proxyHost + ':' + self.proxyPort;
+
+      if (req)
+        req.emit('error', err);
+      else
+        throw err;
+
+      return;
+    }
+
+    if(!self.sockets[name]) self.sockets[name] = [];
+
+    self.sockets[name].push(s);
+
+    var onFree = function (){
+      self.emit('free', s, host, port, localAddress);
+    };
+
+    var onClose = function (err){
+      // this is the only place where sockets get removed from the Agent.
+      // if you want to remove a socket from the pool, just close it.
+      // all socket errors end in a close event anyway.
+      self.removeSocket(s, name, host, port, localAddress);
+    };
+
+    var onRemove = function (){
+      // we need this function for cases like HTTP 'upgrade'
+      // (defined by WebSockets) where we need to remove a socket from the pool
+      // because it'll be locked up indefinitely
+      self.removeSocket(s, name, host, port, localAddress);
+      s.removeListener('close', onClose);
+      s.removeListener('free', onFree);
+      s.removeListener('agentRemove', onRemove);
+    };
+
+    s.on('free', onFree);
+    s.on('close', onClose);
+    s.on('agentRemove', onRemove);
+
+    callback(s);
+  });
+};
+
+module.exports = HttpsProxyAgent;

lib/Local.js

@@ -199,7 +199,12 @@ function Local(){
   this.getBinaryPath = function(callback){
     if(typeof(this.binaryPath) == 'undefined'){
       this.binary = new LocalBinary();
-      this.binary.binaryPath(callback);
+      var conf = {};
+      if(this.proxyHost && this.proxyPort){
+        conf.proxyHost = this.proxyHost;
+        conf.proxyPort = this.proxyPort;
+      }
+      this.binary.binaryPath(conf, callback);
     } else {
       callback(this.binaryPath);
     }

lib/LocalBinary.js

@@ -1,7 +1,9 @@
 var https = require('https'),
+  url = require('url'),
   fs = require('fs'),
   path = require('path'),
   os = require('os'),
+  HttpsProxyAgent = require('./HttpsProxyAgent'),
   LocalError = require('./LocalError');
 
 function LocalBinary(){
@@ -20,15 +22,23 @@ function LocalBinary(){
       this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-ia32';
   }
 
-  this.download = function(destParentDir, callback){
+  this.download = function(conf, destParentDir, callback){
     if(!this.checkPath(destParentDir))
       fs.mkdirSync(destParentDir);
 
     var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
     var binaryPath = path.join(destParentDir, destBinaryName);
     var file = fs.createWriteStream(binaryPath);
 
-    https.get(this.httpPath, function (response) {
+    var options = url.parse(this.httpPath);
+    if(conf.proxyHost && conf.proxyPort){
+      options.agent = new HttpsProxyAgent({
+        proxyHost: conf.proxyHost,
+        proxyPort: conf.proxyPort
+      });
+    }
+
+    https.get(options, function (response) {
       response.on('end', function () {
         fs.chmod(binaryPath, '0755', function() {
           callback(binaryPath);
@@ -38,14 +48,14 @@ function LocalBinary(){
     });
   };
 
-  this.binaryPath = function(callback){
+  this.binaryPath = function(conf, callback){
     var destParentDir = this.getAvailableDirs();
     var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
     var binaryPath = path.join(destParentDir, destBinaryName);
     if(this.checkPath(binaryPath, fs.X_OK)){
       callback(binaryPath);
     } else {
-      this.download(destParentDir, callback);
+      this.download(conf, destParentDir, callback);
     }
   };