UIVideoPlayer-ios.mm regression fix. (cocos2d#20368)

dave-ori · Mike Chen · commit b9d4a53043fe · 2020-01-20T13:44:18.000-08:00
[UIVideoViewWrapperIos clean] shouldn't reset _videoPlayer pointer,
since it is called in setUrl method and leaves instance in invalid
state. Subsequent calls to play, pause, etc. end up with crash.
diff --git a/cocos/ui/UIVideoPlayer-ios.mm b/cocos/ui/UIVideoPlayer-ios.mm
@@ -103,14 +103,14 @@ -(id)init:(void*)videoPlayer
 
 -(void) dealloc
 {
+    _videoPlayer = nullptr;
     [self clean];
     [self.playerController release];
     [super dealloc];
 }
 
 -(void) clean
 {
-    _videoPlayer = nullptr;
     [self stop];
     [self removePlayerEventListener];
     [self.playerController.view removeFromSuperview];

Original file line number	Diff line number	Diff line change
`@@ -103,14 +103,14 @@ -(id)init:(void*)videoPlayer`
`103`	`103`
`104`	`104`	`-(void) dealloc`
`105`	`105`	`{`
	`106`	`+ _videoPlayer = nullptr;`
`106`	`107`	`[self clean];`
`107`	`108`	`[self.playerController release];`
`108`	`109`	`[super dealloc];`
`109`	`110`	`}`
`110`	`111`
`111`	`112`	`-(void) clean`
`112`	`113`	`{`
`113`		`- _videoPlayer = nullptr;`
`114`	`114`	`[self stop];`
`115`	`115`	`[self removePlayerEventListener];`
`116`	`116`	`[self.playerController.view removeFromSuperview];`