Skip to content

fix(terraform_plan): use provider name not resource address to fix supported_provider matching #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(terraform_plan): use provider name not resource address to fix supported_provider matching #7119

wants to merge 1 commit into from

Conversation

alanszlosek
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fix matching of supported_provider values.

Use the provider name (not the key from the plan which can contain the provider alias) in the provider_map data structure, since this is what supported_provider is compared against. Otherwise, some provider checks will only run against providers without an alias.

Fixes #7118

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform Plan scanning only runs provider checks against providers without an alias
1 participant
@alanszlosek