Refactor/friend view calendar fetch #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinwoong16
reviewed
Dec 12, 2022
Collaborator
jinwoong16
left a comment
jinwoong16
left a comment
There was a problem hiding this comment.
์บ๋ฆฐ๋ ์ฒ๋ฆฌ๊ฐ ๋๋๊ฒ๊ฐ์์ ๋คํ์ด๋ค์. ๋จ์๋ ๊น์ง ์ ๋ง๋ฌด๋ฆฌํด๋ด ์๋ค! ๊ณ ์๋ง์ผ์ จ์ต๋๋ค.
| import RxSwift | ||
|
|
||
| final class DefaultFriendCalendarUseCase: FriendCalendarUseCase { | ||
| final class DefaultFriendCalendarUseCase: CalendarUseCase { |
Collaborator
There was a problem hiding this comment.
๊ธฐ์กด๊ณผ ๋งฅ๋ฝ์ ๋์ผํ ๋ก์ง์ด๋ผ๋ฉด ๋๋ ค์ฐ๋๊ฒ ์ข๊ธดํ๊ฒ๊ฐ์ต๋๋ค !
| } | ||
|
|
||
| func makeFriendCalendarUseCase(with user: User) -> FriendCalendarUseCase { | ||
| func makeFriendCalendarUseCase(with user: User) -> CalendarUseCase { |
Collaborator
There was a problem hiding this comment.
์ด๋ถ๋ถ ์ฐธ๊ณ ํด์, DI Container ๋ณ๊ฒฝ๋๋ ๋ถ๋ถ์ ์ฒ๋ฆฌํด์ผ๊ฒ ์ต๋๋ค. ๊ณ ์ํ์ จ์ต๋๋ค!
Member
|
ํ๋ฅญํฉ๋๋ค~~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Issue Number
Close #148
๐ ์์ ๋ด์ญ
๐ ์์ ์ ํ
๐ ์ฒดํฌ๋ฆฌ์คํธ
๐ PR ํน์ด ์ฌํญ
DefaultFriendCalendarUseCase์์ map์ผ๋ก ์๋ ์ฌ์ฉํ๋ ๋ฐ์ดํฐํ์ ์ผ๋ก ๋ณ๊ฒฝํ๋ ์ฝ๋๋ก ๊ตฌํํ์ต๋๋ค.