ParsePatchHeader failing on dependabot emails

[alam-chime]

From a94db29e472831db7a75ba52e99ab717c17886eb Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <59619111+dependabot[bot]@users.noreply.github.com>
Date: Mon, 29 Apr 2024 17:31:28 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9C=85=20(deps):=20Bump=20schemas=20fr?=
 =?UTF-8?q?om=202.11.20240425191412=20to=202.11.20240429164216=20(#10143)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 Gemfile.lock | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Gemfile.lock b/Gemfile.lock
index 5b1718812c..5e83f3d1fa 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -109,7 +109,7 @@ GEM
       faraday
       flipper
       jwt
-    schemas (2.11.20240425191412)
+    schemas (2.11.20240429164216)
       google-protobuf (~> 3.21)
       googleapis-common-protos-types
       twirp (>= 1.7)

For the above patch, ParsePatchHeader is failing with mail: missing @ in addr-spec. I completely understand that the email 59619111+dependabot[bot]@users.noreply.github.com is invalid, and the code for parsing logic belongs to net/mail package. Just wanted to post it hear anyways to hear your thoughts on it. Please close it as invalid if it's not worth your time. Thank you!

[bluekeyes]

Thanks for reporting this. I'm guessing that git will accept this patch, but I'll need to test - if it does, then this library should accept it as well.

[bluekeyes]

Git happily accepts this email format, so I consider this a bug in go-gitdiff. To fix it, I need to avoid the net/mail package for this parsing and use the existing ParsePatchIdentity function. But after reviewing how Git handles the From line, that function also needs some updates so the full fix here is more involved. I'll hopefully have something in the next few days.