From 8347b231714fbf8fdc53e659005620ee4e0728da Mon Sep 17 00:00:00 2001 From: Titian Cernicova-Dragomir Date: Tue, 16 Jan 2024 16:41:47 +0000 Subject: [PATCH 1/3] Remove stale diff reasons. Signed-off-by: Titian Cernicova-Dragomir --- src/harness/harnessIO.ts | 8 ---- src/testRunner/compilerRunner.ts | 47 ++++++++++++------- tests/cases/compiler/arrayFind.ts | 1 - tests/cases/compiler/bigintIndex.ts | 1 - tests/cases/compiler/booleanFilterAnyArray.ts | 1 - .../capturedParametersInInitializers1.ts | 1 - .../circularObjectLiteralAccessors.ts | 1 - tests/cases/compiler/complicatedPrivacy.ts | 1 - tests/cases/compiler/constEnumErrors.ts | 1 - tests/cases/compiler/contextualTyping.ts | 1 - tests/cases/compiler/contextualTyping38.ts | 1 - tests/cases/compiler/contextualTyping39.ts | 1 - ...dataWithImportDeclarationNameCollision7.ts | 1 - .../decoratorsOnComputedProperties.ts | 1 - ...cateObjectLiteralProperty_computedName1.ts | 1 - ...cateObjectLiteralProperty_computedName2.ts | 1 - .../duplicateVarsAcrossFileBoundaries.ts | 1 - tests/cases/compiler/escapedIdentifiers.ts | 1 - tests/cases/compiler/forwardRefInEnum.ts | 1 - .../cases/compiler/gettersAndSettersErrors.ts | 1 - .../compiler/inKeywordAndIntersection.ts | 1 - .../indexSignatureMustHaveTypeAnnotation.ts | 1 - .../cases/compiler/indexWithoutParamType2.ts | 1 - tests/cases/compiler/intTypeCheck.ts | 1 - ...ErrorFromUsingES6FeaturesWithOnlyES5Lib.ts | 3 +- ...lutionWithSuffixes_one_externalTSModule.ts | 1 - .../objectLiteralEnumPropertyNames.ts | 1 - .../compiler/overloadsWithComputedNames.ts | 1 - .../compiler/parseInvalidNonNullableTypes.ts | 1 - .../compiler/parseInvalidNullableTypes.ts | 1 - tests/cases/compiler/parseTypes.ts | 1 - tests/cases/compiler/propertyAssignment.ts | 1 - .../compiler/typeUsedAsTypeLiteralIndex.ts | 1 - .../conformance/Symbols/ES5SymbolProperty1.ts | 1 - .../conformance/Symbols/ES5SymbolProperty2.ts | 1 - .../conformance/Symbols/ES5SymbolProperty3.ts | 1 - .../conformance/Symbols/ES5SymbolProperty4.ts | 1 - .../conformance/Symbols/ES5SymbolProperty5.ts | 1 - .../conformance/Symbols/ES5SymbolProperty6.ts | 1 - .../conformance/Symbols/ES5SymbolProperty7.ts | 1 - .../asyncFunctionDeclaration8_es2017.ts | 1 - .../asyncFunctionDeclaration8_es5.ts | 1 - .../asyncFunctionDeclaration8_es6.ts | 1 - .../derivedClassOverridesProtectedMembers.ts | 1 - .../derivedClassOverridesProtectedMembers2.ts | 1 - .../derivedClassOverridesProtectedMembers3.ts | 1 - .../derivedClassOverridesPublicMembers.ts | 1 - .../staticPropertyNameConflicts.ts | 1 - .../es6/Symbols/symbolProperty1.ts | 1 - .../es6/Symbols/symbolProperty2.ts | 1 - .../es6/Symbols/symbolProperty3.ts | 1 - .../es6/Symbols/symbolProperty52.ts | 1 - .../es6/Symbols/symbolProperty53.ts | 1 - .../es6/Symbols/symbolProperty54.ts | 1 - .../es6/Symbols/symbolProperty58.ts | 1 - .../es6/Symbols/symbolProperty59.ts | 1 - .../computedPropertyNames10_ES5.ts | 1 - .../computedPropertyNames10_ES6.ts | 1 - .../computedPropertyNames11_ES5.ts | 1 - .../computedPropertyNames11_ES6.ts | 1 - .../computedPropertyNames12_ES5.ts | 1 - .../computedPropertyNames12_ES6.ts | 1 - .../computedPropertyNames13_ES5.ts | 1 - .../computedPropertyNames13_ES6.ts | 1 - .../computedPropertyNames14_ES5.ts | 1 - .../computedPropertyNames14_ES6.ts | 1 - .../computedPropertyNames15_ES5.ts | 1 - .../computedPropertyNames15_ES6.ts | 1 - .../computedPropertyNames16_ES5.ts | 1 - .../computedPropertyNames16_ES6.ts | 1 - .../computedPropertyNames17_ES5.ts | 1 - .../computedPropertyNames17_ES6.ts | 1 - .../computedPropertyNames2_ES5.ts | 1 - .../computedPropertyNames2_ES6.ts | 1 - .../computedPropertyNames4_ES5.ts | 1 - .../computedPropertyNames4_ES6.ts | 1 - .../computedPropertyNames5_ES5.ts | 1 - .../computedPropertyNames5_ES6.ts | 1 - .../computedPropertyNames6_ES5.ts | 1 - .../computedPropertyNames6_ES6.ts | 1 - .../computedPropertyNames7_ES5.ts | 1 - .../computedPropertyNames7_ES6.ts | 1 - .../computedPropertyNamesOnOverloads_ES5.ts | 1 - .../computedPropertyNamesOnOverloads_ES6.ts | 1 - ...computedPropertyNamesWithStaticProperty.ts | 1 - .../FunctionDeclaration8_es6.ts | 2 - .../MemberFunctionDeclaration3_es6.ts | 1 - .../expressions/asOperator/asOperator1.ts | 1 - .../generatedContextualTyping.ts | 1 - .../objectLiteralGettersAndSetters.ts | 1 - .../optionalChainingInference.ts | 1 - .../superSymbolIndexedAccess1.ts | 1 - .../superSymbolIndexedAccess3.ts | 1 - .../superSymbolIndexedAccess4.ts | 1 - .../superSymbolIndexedAccess5.ts | 1 - .../superSymbolIndexedAccess6.ts | 1 - .../reExportAliasMakesInstantiated.ts | 1 - ...tionEmitDynamicImportWithPackageExports.ts | 1 - .../parserES5ComputedPropertyName1.ts | 1 - .../parserES5ComputedPropertyName10.ts | 1 - .../parserES5ComputedPropertyName11.ts | 1 - .../parserES5ComputedPropertyName2.ts | 1 - .../parserES5ComputedPropertyName3.ts | 1 - .../parserES5ComputedPropertyName4.ts | 1 - .../parserES5ComputedPropertyName5.ts | 1 - .../parserES5ComputedPropertyName7.ts | 1 - .../parserES5ComputedPropertyName8.ts | 1 - .../parserES5ComputedPropertyName9.ts | 1 - .../parserCastVersusArrowFunction1.ts | 1 - .../IndexSignatures/parserIndexSignature11.ts | 1 - .../IndexSignatures/parserIndexSignature5.ts | 1 - .../StrictMode/parserStrictMode8.ts | 1 - .../Symbols/parserES5SymbolProperty1.ts | 1 - .../Symbols/parserES5SymbolProperty2.ts | 1 - .../Symbols/parserES5SymbolProperty3.ts | 1 - .../Symbols/parserES5SymbolProperty4.ts | 1 - .../Symbols/parserES5SymbolProperty5.ts | 1 - .../Symbols/parserES5SymbolProperty6.ts | 1 - .../Symbols/parserES5SymbolProperty7.ts | 1 - .../Symbols/parserES5SymbolProperty8.ts | 1 - .../Symbols/parserES5SymbolProperty9.ts | 1 - .../parserComputedPropertyName1.ts | 1 - .../parserComputedPropertyName10.ts | 1 - .../parserComputedPropertyName11.ts | 1 - .../parserComputedPropertyName12.ts | 1 - .../parserComputedPropertyName13.ts | 1 - .../parserComputedPropertyName14.ts | 1 - .../parserComputedPropertyName15.ts | 1 - .../parserComputedPropertyName17.ts | 1 - .../parserComputedPropertyName18.ts | 1 - .../parserComputedPropertyName19.ts | 1 - .../parserComputedPropertyName2.ts | 1 - .../parserComputedPropertyName20.ts | 1 - .../parserComputedPropertyName21.ts | 1 - .../parserComputedPropertyName22.ts | 1 - .../parserComputedPropertyName23.ts | 1 - .../parserComputedPropertyName24.ts | 1 - .../parserComputedPropertyName25.ts | 1 - .../parserComputedPropertyName27.ts | 1 - .../parserComputedPropertyName28.ts | 1 - .../parserComputedPropertyName29.ts | 1 - .../parserComputedPropertyName3.ts | 1 - .../parserComputedPropertyName31.ts | 1 - .../parserComputedPropertyName32.ts | 1 - .../parserComputedPropertyName33.ts | 1 - .../parserComputedPropertyName36.ts | 1 - .../parserComputedPropertyName37.ts | 1 - .../parserComputedPropertyName38.ts | 1 - .../parserComputedPropertyName39.ts | 1 - .../parserComputedPropertyName4.ts | 1 - .../parserComputedPropertyName5.ts | 1 - .../parserComputedPropertyName6.ts | 1 - .../parserComputedPropertyName7.ts | 1 - .../parserComputedPropertyName8.ts | 1 - .../parserComputedPropertyName9.ts | 1 - .../pedantic/noUncheckedIndexedAccess.ts | 1 - .../salsa/typeFromPropertyAssignment32.ts | 1 - .../salsa/typeFromPropertyAssignment33.ts | 1 - .../for-ofStatements/ES5For-ofTypeCheck10.ts | 1 - .../literal/literalTypesAndTypeAssertions.ts | 1 - .../stringLiteralsWithTypeAssertions01.ts | 3 +- .../typeQueries/recursiveTypesWithTypeof.ts | 1 - ...genericTypeReferenceWithoutTypeArgument.ts | 1 - ...enericTypeReferenceWithoutTypeArgument2.ts | 1 - .../types/thisType/thisTypeErrors.ts | 1 - .../types/thisType/thisTypeInAccessors.ts | 1 - .../contextualSignatureInstantiation.ts | 1 - 167 files changed, 31 insertions(+), 194 deletions(-) diff --git a/src/harness/harnessIO.ts b/src/harness/harnessIO.ts index 7f94664897b2f..7fb7013c9c850 100644 --- a/src/harness/harnessIO.ts +++ b/src/harness/harnessIO.ts @@ -1050,10 +1050,6 @@ export namespace Compiler { fullDiff += Diff.createTwoFilesPatch("TSC", "DTE", tscContent, dteContent, "declarations", "declarations"); Baseline.runBaseline(type + "/" + baselinePath.replace(/\.tsx?/, `.d.ts.map.diff`), fullDiff); - - if (reason === undefined) { - throw new Error("The test is not equivalent between TSC and DTE. Please provide an isolatedDeclarationDiffReason/isolatedDeclarationFixedDiffReason setting in the test if this is intentional"); - } } export function doDeclarationDiffBaseline( @@ -1077,10 +1073,6 @@ export namespace Compiler { fullDiff += Diff.createTwoFilesPatch("TSC", "DTE", tscContent, dteContent, "declarations", "declarations"); Baseline.runBaseline(type + "/" + baselinePath.replace(/\.tsx?/, `.d.ts.diff`), fullDiff); - - if (reason === undefined) { - throw new Error("The test is not equivalent between TSC and DTE. Please provide an isolatedDeclarationDiffReason/isolatedDeclarationFixedDiffReason setting in the test if this is intentional"); - } } function sourceContent(tsSources: readonly TestFile[]) { let code = ""; diff --git a/src/testRunner/compilerRunner.ts b/src/testRunner/compilerRunner.ts index c35255d92b268..c2a01ad0c6b0a 100644 --- a/src/testRunner/compilerRunner.ts +++ b/src/testRunner/compilerRunner.ts @@ -128,6 +128,7 @@ export class CompilerBaselineRunner extends RunnerBase { it(`Correct dte emit for ${fileName}`, () => isolatedTest?.verifyDteOutput()); it(`Correct tsc emit for ${fileName}`, () => isolatedTest?.verifyTscOutput()); it(`Correct dte/tsc diff ${fileName}`, () => isolatedTest?.verifyDiff()); + it(`Correct diff reason ${fileName}`, () => isolatedTest?.verifyDiffReason()); after(() => { isolatedTest = undefined!; @@ -141,7 +142,8 @@ export class CompilerBaselineRunner extends RunnerBase { if (fixedIsolatedTestEnv) { fixedIsolatedTest = new FixedIsolatedDeclarationTest(fixedIsolatedTestEnv); } - else { + else if(!environment.compilerOptions.isolatedDeclarationDiffReason) { + // Don't skip if they have a reason we need to fail if unused reasons exist this.skip(); } }); @@ -151,6 +153,7 @@ export class CompilerBaselineRunner extends RunnerBase { it(`Correct dte map emit for ${fileName}`, () => fixedIsolatedTest?.verifyDteMapOutput()); it(`Correct tsc map emit for ${fileName}`, () => fixedIsolatedTest?.verifyTscMapOutput()); it(`Correct dte/tsc map diff ${fileName}`, () => fixedIsolatedTest?.verifyMapDiff()); + it(`Correct diff reason ${fileName}`, () => fixedIsolatedTest?.verifyDiffReason()); after(() => { fixedIsolatedTest = undefined!; @@ -480,13 +483,15 @@ class IsolatedDeclarationTest extends CompilerTestBase { protected isDiagnosticEquivalent: boolean; protected isOutputMapEquivalent: boolean; - static transformEnvironment(compilerEnvironment: CompilerTestEnvironment): CompilerTestEnvironment | undefined { + static transformEnvironment(compilerEnvironment: CompilerTestEnvironment, shouldNotExclude = !!compilerEnvironment.testCaseContent.settings.isolatedDeclarationDiffReason): CompilerTestEnvironment | undefined { const options = compilerEnvironment.compilerOptions; - // Exclude tests some tests - // - those explicitly not opting into isolatedDeclarations - // - those that do not usually emit output anyway - if (options.isolatedDeclarations === false || options.noEmit || options.noTypesAndSymbols || !options.declaration) { - return undefined; + if (!shouldNotExclude) { + // Exclude tests some tests + // - those explicitly not opting into isolatedDeclarations + // - those that do not usually emit output anyway + if((options.isolatedDeclarations === false || options.noEmit || options.noTypesAndSymbols || !options.declaration)) { + return undefined; + } } const clonedOptions: ts.CompilerOptions & Compiler.HarnessOptions = ts.cloneCompilerOptions(compilerEnvironment.compilerOptions); if (clonedOptions.isolatedDeclarations === undefined) { @@ -658,11 +663,15 @@ class IsolatedDeclarationTest extends CompilerTestBase { ); } + verifyDiffReason() { + if (this.isOutputMapEquivalent && this.isOutputEquivalent && this.isDiagnosticEquivalent) { + ts.Debug.assert(this.diffReason === undefined, "Should not have a diff reason if everything is equivalent"); + }else { + ts.Debug.assert(this.diffReason !== undefined, "Should have a reason if everything is not equivalent"); + } + } verifyDiff() { if (this.isOutputEquivalent && this.isDiagnosticEquivalent) { - if (this.isOutputMapEquivalent) { - ts.Debug.assert(this.diffReason === undefined, "Should not have a diff reason if everything is equivalent"); - } return; } Compiler.doDeclarationDiffBaseline( @@ -697,16 +706,18 @@ class IsolatedDeclarationTest extends CompilerTestBase { } class FixedIsolatedDeclarationTest extends IsolatedDeclarationTest { - static fixTestProject(compilerEnvironment: CompilerTestEnvironment): CompilerTestEnvironment | undefined { - // Exclude test that disable types and symbols (good proxy for very complex test) - if (compilerEnvironment.compilerOptions.noTypesAndSymbols) { - return undefined; - } - if (!compilerEnvironment.compilerOptions.declaration) { - return undefined; + static fixTestProject(compilerEnvironment: CompilerTestEnvironment, shouldNotExclude = !!compilerEnvironment.testCaseContent.settings.isolatedDeclarationFixedDiffReason): CompilerTestEnvironment | undefined { + if(!shouldNotExclude) { + // Exclude test that disable types and symbols (good proxy for very complex test) + if (compilerEnvironment.compilerOptions.noTypesAndSymbols) { + return undefined; + } + if (!compilerEnvironment.compilerOptions.declaration) { + return undefined; + } } - const env = IsolatedDeclarationTest.transformEnvironment(compilerEnvironment); + const env = IsolatedDeclarationTest.transformEnvironment(compilerEnvironment, shouldNotExclude); if (!env) { return undefined; } diff --git a/tests/cases/compiler/arrayFind.ts b/tests/cases/compiler/arrayFind.ts index 80505ee58ad7a..90883974766b7 100644 --- a/tests/cases/compiler/arrayFind.ts +++ b/tests/cases/compiler/arrayFind.ts @@ -1,5 +1,4 @@ // @lib: es2015 -// @isolatedDeclarationDiffReason: TS normalizes types // test fix for #18112, type guard predicates should narrow returned element function isNumber(x: any): x is number { diff --git a/tests/cases/compiler/bigintIndex.ts b/tests/cases/compiler/bigintIndex.ts index 86a23489d66f1..a959eac590f05 100644 --- a/tests/cases/compiler/bigintIndex.ts +++ b/tests/cases/compiler/bigintIndex.ts @@ -1,5 +1,4 @@ // @target: es2020 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @filename: a.ts interface BigIntIndex { diff --git a/tests/cases/compiler/booleanFilterAnyArray.ts b/tests/cases/compiler/booleanFilterAnyArray.ts index 66f2ed3ca6c53..e7a7814ca0ea7 100644 --- a/tests/cases/compiler/booleanFilterAnyArray.ts +++ b/tests/cases/compiler/booleanFilterAnyArray.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types interface Bullean { } interface BulleanConstructor { new(v1?: any): Bullean; diff --git a/tests/cases/compiler/capturedParametersInInitializers1.ts b/tests/cases/compiler/capturedParametersInInitializers1.ts index 12a879dbaaf5f..be989e92f8bcf 100644 --- a/tests/cases/compiler/capturedParametersInInitializers1.ts +++ b/tests/cases/compiler/capturedParametersInInitializers1.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: TS normalizes types // ok - usage is deferred function foo1(y = class {c = x}, x = 1) { new y().c; diff --git a/tests/cases/compiler/circularObjectLiteralAccessors.ts b/tests/cases/compiler/circularObjectLiteralAccessors.ts index 028c0af486e8f..3546ee75e6f75 100644 --- a/tests/cases/compiler/circularObjectLiteralAccessors.ts +++ b/tests/cases/compiler/circularObjectLiteralAccessors.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS merges accessors with the same type. DTE can only merge if one type is specified. // @target: es5 // Repro from #6000 diff --git a/tests/cases/compiler/complicatedPrivacy.ts b/tests/cases/compiler/complicatedPrivacy.ts index dc60d06ec2610..774a2244f97fc 100644 --- a/tests/cases/compiler/complicatedPrivacy.ts +++ b/tests/cases/compiler/complicatedPrivacy.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC module m1 { export module m2 { diff --git a/tests/cases/compiler/constEnumErrors.ts b/tests/cases/compiler/constEnumErrors.ts index 1d8529330ace9..ca2289ef3bf33 100644 --- a/tests/cases/compiler/constEnumErrors.ts +++ b/tests/cases/compiler/constEnumErrors.ts @@ -1,5 +1,4 @@ // @lib: es5 -// @isolatedDeclarationDiffReason: TSC detects forward ref which is not allowed and so enum value is undefined, which is also the way we detect isolated declaration errors. const enum E { A } diff --git a/tests/cases/compiler/contextualTyping.ts b/tests/cases/compiler/contextualTyping.ts index 7fe7307cccdfc..73a75d0146623 100644 --- a/tests/cases/compiler/contextualTyping.ts +++ b/tests/cases/compiler/contextualTyping.ts @@ -1,5 +1,4 @@ // @sourcemap: true -// @isolatedDeclarationDiffReason: TS normalizes types // DEFAULT INTERFACES interface IFoo { n: number; diff --git a/tests/cases/compiler/contextualTyping38.ts b/tests/cases/compiler/contextualTyping38.ts index fd383e75e3227..d6533d168267a 100644 --- a/tests/cases/compiler/contextualTyping38.ts +++ b/tests/cases/compiler/contextualTyping38.ts @@ -1,2 +1 @@ -// @isolatedDeclarationDiffReason: TS normalizes types var foo = <{ (): number; }> function(a) { return a }; \ No newline at end of file diff --git a/tests/cases/compiler/contextualTyping39.ts b/tests/cases/compiler/contextualTyping39.ts index cfb3f9002746b..295d9775b0d54 100644 --- a/tests/cases/compiler/contextualTyping39.ts +++ b/tests/cases/compiler/contextualTyping39.ts @@ -1,2 +1 @@ -// @isolatedDeclarationDiffReason: TS normalizes types var foo = <{ (): number; }> function() { return "err"; }; \ No newline at end of file diff --git a/tests/cases/compiler/decoratorMetadataWithImportDeclarationNameCollision7.ts b/tests/cases/compiler/decoratorMetadataWithImportDeclarationNameCollision7.ts index cb289d01fc6e2..76c68dab6cfa2 100644 --- a/tests/cases/compiler/decoratorMetadataWithImportDeclarationNameCollision7.ts +++ b/tests/cases/compiler/decoratorMetadataWithImportDeclarationNameCollision7.ts @@ -3,7 +3,6 @@ // @emitdecoratormetadata: true // @target: es5 // @module: commonjs -// @isolatedDeclarationDiffReason: TSC removes import that is not used in a semantically valid way. DTE can't know about this. // @filename: db.ts export default class db { public doSomething() { diff --git a/tests/cases/compiler/decoratorsOnComputedProperties.ts b/tests/cases/compiler/decoratorsOnComputedProperties.ts index 2e8104041f745..cb9cfe5f9977e 100644 --- a/tests/cases/compiler/decoratorsOnComputedProperties.ts +++ b/tests/cases/compiler/decoratorsOnComputedProperties.ts @@ -1,6 +1,5 @@ // @target: es6 // @experimentalDecorators: true -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC function x(o: object, k: PropertyKey) { } let i = 0; function foo(): string { return ++i + ""; } diff --git a/tests/cases/compiler/duplicateObjectLiteralProperty_computedName1.ts b/tests/cases/compiler/duplicateObjectLiteralProperty_computedName1.ts index bb90c5f89208f..9bc5e2e3d934b 100644 --- a/tests/cases/compiler/duplicateObjectLiteralProperty_computedName1.ts +++ b/tests/cases/compiler/duplicateObjectLiteralProperty_computedName1.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: DTE preserves different duplicate identifier const t1 = { 1: 1, [1]: 0 // duplicate diff --git a/tests/cases/compiler/duplicateObjectLiteralProperty_computedName2.ts b/tests/cases/compiler/duplicateObjectLiteralProperty_computedName2.ts index a34847e44ea65..ff56ce9cfd486 100644 --- a/tests/cases/compiler/duplicateObjectLiteralProperty_computedName2.ts +++ b/tests/cases/compiler/duplicateObjectLiteralProperty_computedName2.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Computed property are not resolved const n = 1; const s = "s"; enum E1 { A = "ENUM_KEY" } diff --git a/tests/cases/compiler/duplicateVarsAcrossFileBoundaries.ts b/tests/cases/compiler/duplicateVarsAcrossFileBoundaries.ts index d2bd47dee4a75..03de4077caf88 100644 --- a/tests/cases/compiler/duplicateVarsAcrossFileBoundaries.ts +++ b/tests/cases/compiler/duplicateVarsAcrossFileBoundaries.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TSC Resolves variable types across files. // @Filename: duplicateVarsAcrossFileBoundaries_0.ts var x = 3; var y = ""; diff --git a/tests/cases/compiler/escapedIdentifiers.ts b/tests/cases/compiler/escapedIdentifiers.ts index 375abf8d69d09..c58c59d9b4241 100644 --- a/tests/cases/compiler/escapedIdentifiers.ts +++ b/tests/cases/compiler/escapedIdentifiers.ts @@ -1,6 +1,5 @@ // @allowUnusedLabels: true // @allowUnreachableCode: true -// @isolatedDeclarationDiffReason: DTE resolves unicode escapes in some cases. /* 0 .. \u0030 diff --git a/tests/cases/compiler/forwardRefInEnum.ts b/tests/cases/compiler/forwardRefInEnum.ts index 7c54a6331e90c..97bc1819d7b38 100644 --- a/tests/cases/compiler/forwardRefInEnum.ts +++ b/tests/cases/compiler/forwardRefInEnum.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TSC detects forward ref which is not allowed and so enum value is undefined, which is also the way we detect isolated declaration errors. enum E1 { // illegal case // forward reference to the element of the same enum diff --git a/tests/cases/compiler/gettersAndSettersErrors.ts b/tests/cases/compiler/gettersAndSettersErrors.ts index 3065b861f9104..fcc26abf6221f 100644 --- a/tests/cases/compiler/gettersAndSettersErrors.ts +++ b/tests/cases/compiler/gettersAndSettersErrors.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Duplicate identifiers in class result in different types class C { public get Foo() { return "foo";} // ok public set Foo(foo:string) {} // ok diff --git a/tests/cases/compiler/inKeywordAndIntersection.ts b/tests/cases/compiler/inKeywordAndIntersection.ts index f81391f3b0f1e..dadf93a8649d0 100644 --- a/tests/cases/compiler/inKeywordAndIntersection.ts +++ b/tests/cases/compiler/inKeywordAndIntersection.ts @@ -1,5 +1,4 @@ // @strict: true -// @isolatedDeclarationDiffReason: TS normalizes types class A { a = 0 } class B { b = 0 } diff --git a/tests/cases/compiler/indexSignatureMustHaveTypeAnnotation.ts b/tests/cases/compiler/indexSignatureMustHaveTypeAnnotation.ts index 2f0b82a252c32..47d818065a1dc 100644 --- a/tests/cases/compiler/indexSignatureMustHaveTypeAnnotation.ts +++ b/tests/cases/compiler/indexSignatureMustHaveTypeAnnotation.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { // Used to be indexer, now it is a computed property [x]: string; diff --git a/tests/cases/compiler/indexWithoutParamType2.ts b/tests/cases/compiler/indexWithoutParamType2.ts index c48f197c94ffa..0def5dc06a911 100644 --- a/tests/cases/compiler/indexWithoutParamType2.ts +++ b/tests/cases/compiler/indexWithoutParamType2.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { // Used to be indexer, now it is a computed property [x]: string diff --git a/tests/cases/compiler/intTypeCheck.ts b/tests/cases/compiler/intTypeCheck.ts index e17aa854c7e57..a156309786353 100644 --- a/tests/cases/compiler/intTypeCheck.ts +++ b/tests/cases/compiler/intTypeCheck.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface i1 { //Property Signatures p; diff --git a/tests/cases/compiler/modularizeLibrary_ErrorFromUsingES6FeaturesWithOnlyES5Lib.ts b/tests/cases/compiler/modularizeLibrary_ErrorFromUsingES6FeaturesWithOnlyES5Lib.ts index 8a9ce2e980093..290cf0e42119f 100644 --- a/tests/cases/compiler/modularizeLibrary_ErrorFromUsingES6FeaturesWithOnlyES5Lib.ts +++ b/tests/cases/compiler/modularizeLibrary_ErrorFromUsingES6FeaturesWithOnlyES5Lib.ts @@ -1,5 +1,4 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC -// @lib: es5 +// @lib: es5 // @target: es6 // All will be error from using ES6 features but only include ES5 library diff --git a/tests/cases/compiler/moduleResolutionWithSuffixes_one_externalTSModule.ts b/tests/cases/compiler/moduleResolutionWithSuffixes_one_externalTSModule.ts index b2bd6ddb0599e..7e5afac88ee0f 100644 --- a/tests/cases/compiler/moduleResolutionWithSuffixes_one_externalTSModule.ts +++ b/tests/cases/compiler/moduleResolutionWithSuffixes_one_externalTSModule.ts @@ -1,5 +1,4 @@ // moduleSuffixes has one entry and there's a matching package with TS files. -// @isolatedDeclarationDiffReason: checker.typeToTypeNode deliberately fails on types that originate from node_modules // @fullEmitPaths: true // @filename: /tsconfig.json { diff --git a/tests/cases/compiler/objectLiteralEnumPropertyNames.ts b/tests/cases/compiler/objectLiteralEnumPropertyNames.ts index 578c47c4f67e5..0f698d9c51d8d 100644 --- a/tests/cases/compiler/objectLiteralEnumPropertyNames.ts +++ b/tests/cases/compiler/objectLiteralEnumPropertyNames.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Computed property are not resolved // Fixes #16887 enum Strs { A = 'a', diff --git a/tests/cases/compiler/overloadsWithComputedNames.ts b/tests/cases/compiler/overloadsWithComputedNames.ts index ff2b3d5e57639..810beff88874c 100644 --- a/tests/cases/compiler/overloadsWithComputedNames.ts +++ b/tests/cases/compiler/overloadsWithComputedNames.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // https://github.com/microsoft/TypeScript/issues/52329 class Person { ["B"](a: number): string; diff --git a/tests/cases/compiler/parseInvalidNonNullableTypes.ts b/tests/cases/compiler/parseInvalidNonNullableTypes.ts index 468f5be1a70ab..f1ad19c6a2d98 100644 --- a/tests/cases/compiler/parseInvalidNonNullableTypes.ts +++ b/tests/cases/compiler/parseInvalidNonNullableTypes.ts @@ -1,5 +1,4 @@ // @strict: true -// @isolatedDeclarationDiffReason: Syntactically invalid. function f1(a: string): a is string! { return true; diff --git a/tests/cases/compiler/parseInvalidNullableTypes.ts b/tests/cases/compiler/parseInvalidNullableTypes.ts index f7f5c7fc7750c..f7d9f2643513e 100644 --- a/tests/cases/compiler/parseInvalidNullableTypes.ts +++ b/tests/cases/compiler/parseInvalidNullableTypes.ts @@ -1,5 +1,4 @@ // @strict: true -// @isolatedDeclarationDiffReason: Syntactically invalid. function f1(a: string): a is ?string { return true; diff --git a/tests/cases/compiler/parseTypes.ts b/tests/cases/compiler/parseTypes.ts index 8c6407d05b5e7..c259deb2a2aa3 100644 --- a/tests/cases/compiler/parseTypes.ts +++ b/tests/cases/compiler/parseTypes.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types var x = <() => number>null; var y = <{(): number; }>null; diff --git a/tests/cases/compiler/propertyAssignment.ts b/tests/cases/compiler/propertyAssignment.ts index 3ebddff41838e..0c8351fb05d2f 100644 --- a/tests/cases/compiler/propertyAssignment.ts +++ b/tests/cases/compiler/propertyAssignment.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Syntactically invalid. var foo1: { new ():any; } diff --git a/tests/cases/compiler/typeUsedAsTypeLiteralIndex.ts b/tests/cases/compiler/typeUsedAsTypeLiteralIndex.ts index 3626c45634d12..908491330e206 100644 --- a/tests/cases/compiler/typeUsedAsTypeLiteralIndex.ts +++ b/tests/cases/compiler/typeUsedAsTypeLiteralIndex.ts @@ -1,5 +1,4 @@ // @target: esnext -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC type K = number | string; type T = { diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty1.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty1.ts index 9128979e905d0..8a9276416c5e4 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty1.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty1.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface SymbolConstructor { foo: string; } diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty2.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty2.ts index 14d3c5668d7bd..6bfce5fc58ddb 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty2.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty2.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 module M { var Symbol: any; diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty3.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty3.ts index de77c6b169495..a6eecc721241d 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty3.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty3.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var Symbol: any; diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty4.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty4.ts index c7fb56b65ed5a..2b14e64a33ced 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty4.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty4.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var Symbol: { iterator: string }; diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty5.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty5.ts index 012c3cdb5ff0d..ec46ddad21dc1 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty5.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var Symbol: { iterator: symbol }; diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty6.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty6.ts index 20c0fdc0165f1..59b7d2291aada 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty6.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 class C { [Symbol.iterator]() { } diff --git a/tests/cases/conformance/Symbols/ES5SymbolProperty7.ts b/tests/cases/conformance/Symbols/ES5SymbolProperty7.ts index 517bd01a069bb..766b86f9b5d33 100644 --- a/tests/cases/conformance/Symbols/ES5SymbolProperty7.ts +++ b/tests/cases/conformance/Symbols/ES5SymbolProperty7.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var Symbol: { iterator: any }; diff --git a/tests/cases/conformance/async/es2017/functionDeclarations/asyncFunctionDeclaration8_es2017.ts b/tests/cases/conformance/async/es2017/functionDeclarations/asyncFunctionDeclaration8_es2017.ts index 4cc015a22f86e..64e62a2719ef0 100644 --- a/tests/cases/conformance/async/es2017/functionDeclarations/asyncFunctionDeclaration8_es2017.ts +++ b/tests/cases/conformance/async/es2017/functionDeclarations/asyncFunctionDeclaration8_es2017.ts @@ -1,4 +1,3 @@ // @target: es2017 // @noEmitHelpers: true -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [await]: foo } \ No newline at end of file diff --git a/tests/cases/conformance/async/es5/functionDeclarations/asyncFunctionDeclaration8_es5.ts b/tests/cases/conformance/async/es5/functionDeclarations/asyncFunctionDeclaration8_es5.ts index b443fe619194f..27db170b08039 100644 --- a/tests/cases/conformance/async/es5/functionDeclarations/asyncFunctionDeclaration8_es5.ts +++ b/tests/cases/conformance/async/es5/functionDeclarations/asyncFunctionDeclaration8_es5.ts @@ -1,5 +1,4 @@ // @target: ES5 // @lib: es5,es2015.promise // @noEmitHelpers: true -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [await]: foo } \ No newline at end of file diff --git a/tests/cases/conformance/async/es6/functionDeclarations/asyncFunctionDeclaration8_es6.ts b/tests/cases/conformance/async/es6/functionDeclarations/asyncFunctionDeclaration8_es6.ts index 128db35bce16a..764b0f3fb8a79 100644 --- a/tests/cases/conformance/async/es6/functionDeclarations/asyncFunctionDeclaration8_es6.ts +++ b/tests/cases/conformance/async/es6/functionDeclarations/asyncFunctionDeclaration8_es6.ts @@ -1,4 +1,3 @@ // @target: ES6 // @noEmitHelpers: true -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [await]: foo } \ No newline at end of file diff --git a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers.ts b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers.ts index a59887c6f70d8..76c03c73d6336 100644 --- a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers.ts +++ b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types // @target: ES5 var x: { foo: string; } diff --git a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers2.ts b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers2.ts index 94047c58376fd..fb1955f1d952d 100644 --- a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers2.ts +++ b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers2.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types // @target: ES5 var x: { foo: string; } var y: { foo: string; bar: string; } diff --git a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers3.ts b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers3.ts index a55b2a6dc596e..d24e313c24093 100644 --- a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers3.ts +++ b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesProtectedMembers3.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types // @target: ES5 var x: { foo: string; } diff --git a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesPublicMembers.ts b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesPublicMembers.ts index 99925431cebed..eebed0cd5c6a5 100644 --- a/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesPublicMembers.ts +++ b/tests/cases/conformance/classes/members/inheritanceAndOverriding/derivedClassOverridesPublicMembers.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types var x: { foo: string; } var y: { foo: string; bar: string; } diff --git a/tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts b/tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts index 0dc092393bb60..71096e7b8f313 100644 --- a/tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts +++ b/tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts @@ -1,6 +1,5 @@ // @target: es5 // @useDefineForClassFields: true,false -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC const FunctionPropertyNames = { name: 'name', diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty1.ts b/tests/cases/conformance/es6/Symbols/symbolProperty1.ts index b8c11d1eaed4f..0e008511be3fe 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty1.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty1.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: symbol; var x = { [s]: 0, diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty2.ts b/tests/cases/conformance/es6/Symbols/symbolProperty2.ts index e9cb71d98139a..44a2ba1387464 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty2.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty2.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s = Symbol(); var x = { [s]: 0, diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty3.ts b/tests/cases/conformance/es6/Symbols/symbolProperty3.ts index 5b4a1586269e0..027e93a86adfb 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty3.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty3.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s = Symbol; var x = { [s]: 0, diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty52.ts b/tests/cases/conformance/es6/Symbols/symbolProperty52.ts index 30bfb844b22cb..b14838a6914b4 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty52.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty52.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var obj = { [Symbol.nonsense]: 0 }; diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty53.ts b/tests/cases/conformance/es6/Symbols/symbolProperty53.ts index bd03fd5fb3eb2..c58b6e885afcc 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty53.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty53.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var obj = { [Symbol.for]: 0 }; diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty54.ts b/tests/cases/conformance/es6/Symbols/symbolProperty54.ts index 6853d64020344..b3eab2a54a154 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty54.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty54.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var obj = { [Symbol.prototype]: 0 }; \ No newline at end of file diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty58.ts b/tests/cases/conformance/es6/Symbols/symbolProperty58.ts index f4d18e76e2443..48cc6eb90f32c 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty58.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty58.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface SymbolConstructor { foo: string; } diff --git a/tests/cases/conformance/es6/Symbols/symbolProperty59.ts b/tests/cases/conformance/es6/Symbols/symbolProperty59.ts index a63831a80232e..bdea9dab62c28 100644 --- a/tests/cases/conformance/es6/Symbols/symbolProperty59.ts +++ b/tests/cases/conformance/es6/Symbols/symbolProperty59.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [Symbol.keyFor]: string; } \ No newline at end of file diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES5.ts index 8746d4950a6e0..59a8e9d34200d 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es5 var s: string; var n: number; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES6.ts index d90af9f003620..0ab74d788c832 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames10_ES6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 var s: string; var n: number; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES5.ts index 693cb7ef13d39..33288184b16d6 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES6.ts index 68457f8f8ade9..d41c56fe953ed 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames11_ES6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 var s: string; var n: number; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES5.ts index d7cb1544e2d26..365ca67c1a39b 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES6.ts index 91286f90d9d8b..e046899d3310d 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames12_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES5.ts index 7e0f5379b38db..fb44bfb41452a 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es5 var s: string; var n: number; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES6.ts index fc91cb9d237c9..de40dc4e774ea 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames13_ES6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 var s: string; var n: number; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES5.ts index 07d5febbdd480..8f78f279eba2f 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es5 var b: boolean; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES6.ts index 6ba3016e523e6..d90f2d7f9767d 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames14_ES6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 var b: boolean; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES5.ts index a961b1e83af65..2baa39cf61ae7 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es5 var p1: number | string; var p2: number | number[]; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES6.ts index 2a271f40534b1..60b62d2903496 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames15_ES6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 var p1: number | string; var p2: number | number[]; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES5.ts index 826700ed18f30..01204a1e61949 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES6.ts index b6b4c6b39cd24..c42e6e97177e5 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames16_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES5.ts index 9aeb797ffd135..e52067cc7f42e 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es5 var b: boolean; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES6.ts index ae8268a23f8fb..d795b527d064d 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames17_ES6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 var b: boolean; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES5.ts index c8400f36d86d5..7c2517cd5145a 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var methodName = "method"; var accessorName = "accessor"; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES6.ts index d8885d788593a..c63ec81d4e64c 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames2_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var methodName = "method"; var accessorName = "accessor"; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES5.ts index 10faebdb41e75..17089b7244f66 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES6.ts index 67bfc47d38aab..a6d4e17c44a6b 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames4_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var s: string; var n: number; var a: any; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES5.ts index 7811a783d358c..e9d7d6ffab497 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var b: boolean; var v = { [b]: 0, diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES6.ts index 9b348ce58d777..590f819c4e4cc 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames5_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var b: boolean; var v = { [b]: 0, diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES5.ts index 48edc0d6fcf02..0521873d70ca0 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var p1: number | string; var p2: number | number[]; var p3: string | boolean; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES6.ts index 5456d747c63c3..b21b76b03f2cf 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames6_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var p1: number | string; var p2: number | number[]; var p3: string | boolean; diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES5.ts index b3ce0bed7e573..e3b379602b93e 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Computed property are not resolved enum E { member } diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES6.ts index 87ce8b403c68c..5063d1e2d0c64 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNames7_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Computed property are not resolved enum E { member } diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES5.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES5.ts index 19ee4452d7c68..a025a074e3129 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES5.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES5.ts @@ -1,5 +1,4 @@ // @target: es5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var methodName = "method"; var accessorName = "accessor"; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES6.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES6.ts index 0760d3277200e..4d6fe09b80a00 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES6.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNamesOnOverloads_ES6.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var methodName = "method"; var accessorName = "accessor"; class C { diff --git a/tests/cases/conformance/es6/computedProperties/computedPropertyNamesWithStaticProperty.ts b/tests/cases/conformance/es6/computedProperties/computedPropertyNamesWithStaticProperty.ts index 6b3d565e41643..7eccd615bc4c3 100644 --- a/tests/cases/conformance/es6/computedProperties/computedPropertyNamesWithStaticProperty.ts +++ b/tests/cases/conformance/es6/computedProperties/computedPropertyNamesWithStaticProperty.ts @@ -1,5 +1,4 @@ // @target: es6 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { class C1 { static staticProp = 10; diff --git a/tests/cases/conformance/es6/functionDeclarations/FunctionDeclaration8_es6.ts b/tests/cases/conformance/es6/functionDeclarations/FunctionDeclaration8_es6.ts index 2676ee9baa3c6..4b65f204babb1 100644 --- a/tests/cases/conformance/es6/functionDeclarations/FunctionDeclaration8_es6.ts +++ b/tests/cases/conformance/es6/functionDeclarations/FunctionDeclaration8_es6.ts @@ -1,3 +1 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [yield]: foo } \ No newline at end of file diff --git a/tests/cases/conformance/es6/memberFunctionDeclarations/MemberFunctionDeclaration3_es6.ts b/tests/cases/conformance/es6/memberFunctionDeclarations/MemberFunctionDeclaration3_es6.ts index bf95ce89ff9ad..4872449161067 100644 --- a/tests/cases/conformance/es6/memberFunctionDeclarations/MemberFunctionDeclaration3_es6.ts +++ b/tests/cases/conformance/es6/memberFunctionDeclarations/MemberFunctionDeclaration3_es6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC // @target: es6 class C { *[foo]() { } diff --git a/tests/cases/conformance/expressions/asOperator/asOperator1.ts b/tests/cases/conformance/expressions/asOperator/asOperator1.ts index 4a3888eda8392..cf953d75ab46e 100644 --- a/tests/cases/conformance/expressions/asOperator/asOperator1.ts +++ b/tests/cases/conformance/expressions/asOperator/asOperator1.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS changes the order of union constituents var as = 43; var x = undefined as number; var y = (null as string).length; diff --git a/tests/cases/conformance/expressions/contextualTyping/generatedContextualTyping.ts b/tests/cases/conformance/expressions/contextualTyping/generatedContextualTyping.ts index 7316c2eaadc4e..d6bfd84fd9a8c 100644 --- a/tests/cases/conformance/expressions/contextualTyping/generatedContextualTyping.ts +++ b/tests/cases/conformance/expressions/contextualTyping/generatedContextualTyping.ts @@ -1,5 +1,4 @@ // @allowUnreachableCode: true -// @isolatedDeclarationDiffReason: TS normalizes types class Base { private p; } class Derived1 extends Base { private m; } diff --git a/tests/cases/conformance/expressions/objectLiterals/objectLiteralGettersAndSetters.ts b/tests/cases/conformance/expressions/objectLiterals/objectLiteralGettersAndSetters.ts index 1f51edac0b6e9..af0622179ac7f 100644 --- a/tests/cases/conformance/expressions/objectLiterals/objectLiteralGettersAndSetters.ts +++ b/tests/cases/conformance/expressions/objectLiterals/objectLiteralGettersAndSetters.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS merges accessors with the same type. DTE can only merge if one type is specified. // Get and set accessor with the same name var sameName1a = { get 'a'() { return ''; }, set a(n) { var p = n; var p: string; } }; var sameName2a = { get 0.0() { return ''; }, set 0(n) { var p = n; var p: string; } }; diff --git a/tests/cases/conformance/expressions/optionalChaining/optionalChainingInference.ts b/tests/cases/conformance/expressions/optionalChaining/optionalChainingInference.ts index 762d896268866..1b321913a1682 100644 --- a/tests/cases/conformance/expressions/optionalChaining/optionalChainingInference.ts +++ b/tests/cases/conformance/expressions/optionalChaining/optionalChainingInference.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types // https://github.com/microsoft/TypeScript/issues/34579 declare function unbox(box: { value: T | undefined }): T; declare const su: string | undefined; diff --git a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess1.ts b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess1.ts index ee95cee9d15a8..160a76f5c6108 100644 --- a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess1.ts +++ b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess1.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var symbol = Symbol.for('myThing'); diff --git a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess3.ts b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess3.ts index 8656fedbea08b..2fbbbdc63e60a 100644 --- a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess3.ts +++ b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess3.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var symbol = Symbol.for('myThing'); diff --git a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess4.ts b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess4.ts index c87b7cbe90e95..095fcc1dbb7ed 100644 --- a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess4.ts +++ b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess4.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var symbol = Symbol.for('myThing'); diff --git a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess5.ts b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess5.ts index 79e9ec37c6a3c..3c1a376eab6d3 100644 --- a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess5.ts +++ b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var symbol: any; diff --git a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess6.ts b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess6.ts index 19451904a92dd..3850821e9f3de 100644 --- a/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess6.ts +++ b/tests/cases/conformance/expressions/superPropertyAccess/superSymbolIndexedAccess6.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var symbol: any; diff --git a/tests/cases/conformance/internalModules/moduleDeclarations/reExportAliasMakesInstantiated.ts b/tests/cases/conformance/internalModules/moduleDeclarations/reExportAliasMakesInstantiated.ts index 2b6596c1f8503..8d62691b2bc86 100644 --- a/tests/cases/conformance/internalModules/moduleDeclarations/reExportAliasMakesInstantiated.ts +++ b/tests/cases/conformance/internalModules/moduleDeclarations/reExportAliasMakesInstantiated.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: GH#55571 declare module pack1 { const test1: string; export { test1 }; diff --git a/tests/cases/conformance/node/nodeModulesDeclarationEmitDynamicImportWithPackageExports.ts b/tests/cases/conformance/node/nodeModulesDeclarationEmitDynamicImportWithPackageExports.ts index 96c6b33b14c87..ca8c373363ace 100644 --- a/tests/cases/conformance/node/nodeModulesDeclarationEmitDynamicImportWithPackageExports.ts +++ b/tests/cases/conformance/node/nodeModulesDeclarationEmitDynamicImportWithPackageExports.ts @@ -1,7 +1,6 @@ // @module: nodenext // @declaration: true // @isolatedDeclarations: false -// @isolatedDeclarationFixedDiffReason: Skipped due to GH:56394 // @filename: index.ts // esm format file export {}; diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName1.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName1.ts index 3a1ff1b3e16c5..8316cdfbc0e3e 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName1.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName1.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC declare class C { [e]: number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName10.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName10.ts index b4fb51875563b..777c44e01852a 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName10.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName10.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [e] = 1 } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName11.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName11.ts index be39e9a454fae..b5e27ecc71b38 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName11.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName11.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 class C { [e](); diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName2.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName2.ts index 0a02a9bb2e8a8..2f37b0f2cadec 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName2.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName2.ts @@ -1,3 +1,2 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [e]: 1 }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName3.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName3.ts index 0faa43fef992e..5091ee0b98cb3 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName3.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName3.ts @@ -1,3 +1,2 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var v = { [e]() { } }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName4.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName4.ts index b2e78d51c95b3..67b97a6a0bb5e 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName4.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName4.ts @@ -1,3 +1,2 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 var v = { get [e]() { } }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName5.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName5.ts index 544800b9f41df..0507207141078 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName5.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName5.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [e]: number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName7.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName7.ts index 44474c6ab3346..280dc1a5a0ddd 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName7.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName7.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 class C { [e] diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName8.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName8.ts index 43016f76e7926..48abbd6fe9523 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName8.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName8.ts @@ -1,3 +1,2 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v: { [e]: number }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName9.ts b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName9.ts index 9879d507b4556..de00d6f82455a 100644 --- a/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName9.ts +++ b/tests/cases/conformance/parser/ecmascript5/ComputedPropertyNames/parserES5ComputedPropertyName9.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [e]: Type } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Generics/parserCastVersusArrowFunction1.ts b/tests/cases/conformance/parser/ecmascript5/Generics/parserCastVersusArrowFunction1.ts index 272e8e8944e33..f060c9cf7f489 100644 --- a/tests/cases/conformance/parser/ecmascript5/Generics/parserCastVersusArrowFunction1.ts +++ b/tests/cases/conformance/parser/ecmascript5/Generics/parserCastVersusArrowFunction1.ts @@ -1,5 +1,4 @@ // @isolatedDeclarations: false -// @isolatedDeclarationDiffReason: Syntactically invalid. var v = () => 1; var v = a; diff --git a/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature11.ts b/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature11.ts index 65654dbbe7d5f..1c78f24a213b3 100644 --- a/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature11.ts +++ b/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature11.ts @@ -1,4 +1,3 @@ -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [p]; // Used to be indexer, now it is a computed property [p1: string]; diff --git a/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature5.ts b/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature5.ts index 77100fd872c18..e77c8fe9bb08d 100644 --- a/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature5.ts +++ b/tests/cases/conformance/parser/ecmascript5/IndexSignatures/parserIndexSignature5.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [a] // Used to be indexer, now it is a computed property } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/StrictMode/parserStrictMode8.ts b/tests/cases/conformance/parser/ecmascript5/StrictMode/parserStrictMode8.ts index 4f74b2cee5218..7bfe896e7c4d0 100644 --- a/tests/cases/conformance/parser/ecmascript5/StrictMode/parserStrictMode8.ts +++ b/tests/cases/conformance/parser/ecmascript5/StrictMode/parserStrictMode8.ts @@ -1,5 +1,4 @@ // @skipDefaultLibCheck: false -// @isolatedDeclarationDiffReason: Symbol merges with global eval and is not written to declarations. "use strict"; function eval() { } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty1.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty1.ts index 337714a37ea95..64ca01bba6c80 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty1.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty1.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [Symbol.iterator]: string; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty2.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty2.ts index 145aa1047b9be..cc606c2e6a3d5 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty2.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty2.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [Symbol.unscopables](): string; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty3.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty3.ts index 978683bbe9f58..978d4ef95f018 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty3.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty3.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC declare class C { [Symbol.unscopables](): string; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty4.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty4.ts index 6b50a6758b249..7f16672ebd254 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty4.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty4.ts @@ -1,5 +1,4 @@ //@target: ES5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC declare class C { [Symbol.isRegExp]: string; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty5.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty5.ts index ef4197a94222d..fb7f00d769420 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty5.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty5.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [Symbol.isRegExp]: string; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty6.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty6.ts index 35b86c3ee2f0e..3fc8e6f897977 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty6.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty6.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [Symbol.toStringTag]: string = ""; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty7.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty7.ts index d216ba95f86cf..a27636388c074 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty7.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty7.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [Symbol.toStringTag](): void { } } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty8.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty8.ts index 5f1167de7fe75..78e5738f7da8e 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty8.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty8.ts @@ -1,5 +1,4 @@ //@target: ES5 -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var x: { [Symbol.toPrimitive](): string } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty9.ts b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty9.ts index dc6f8b364d92d..7838df4d8fcbf 100644 --- a/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty9.ts +++ b/tests/cases/conformance/parser/ecmascript5/Symbols/parserES5SymbolProperty9.ts @@ -1,5 +1,4 @@ //@target: ES5 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var x: { [Symbol.toPrimitive]: string } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName1.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName1.ts index 47e13ca871f13..e6fbccb8e1f66 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName1.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName1.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [e] }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName10.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName10.ts index 49c3f97e11880..6f87e04e3f569 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName10.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName10.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [e] = 1 } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName11.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName11.ts index 74bd87980a1a0..17af42fcca36a 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName11.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName11.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 class C { [e](); diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName12.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName12.ts index 239f36daca18e..b9b870a9ec930 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName12.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName12.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 class C { [e]() { } diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName13.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName13.ts index c9658123ffb53..809e258d2d484 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName13.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName13.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v: { [e]: number }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName14.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName14.ts index c480df02cf280..3d9fb800d70f5 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName14.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName14.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v: { [e](): number }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName15.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName15.ts index 6fa26e939512f..ba0a7b84b904b 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName15.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName15.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v: { [e: number]: string; [e]: number }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName17.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName17.ts index 292128fee03de..6e6485ea85f31 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName17.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName17.ts @@ -1,3 +1,2 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var v = { set [e](v) { } } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName18.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName18.ts index a09e98727b0ad..dd05fcac48287 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName18.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName18.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v: { [e]?(): number }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName19.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName19.ts index 460c485a8ccc4..f190dadb92c9e 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName19.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName19.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v: { [e]? }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName2.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName2.ts index cd0005248ab76..4efacefce9b8f 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName2.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName2.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [e]: 1 }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName20.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName20.ts index b105256dc8f59..148f07becc15b 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName20.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName20.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [e](): number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName21.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName21.ts index 0fc2f118c282a..f9ec2669ae389 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName21.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName21.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC interface I { [e]: number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName22.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName22.ts index c4e40438a9d87..237a4f4e12ccf 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName22.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName22.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC declare class C { [e]: number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName23.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName23.ts index 161a0d4b51658..633931ad3689f 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName23.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName23.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC declare class C { get [e](): number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName24.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName24.ts index 0acb66a337990..8ff0f753e1fa5 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName24.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName24.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { set [e](v) { } } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName25.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName25.ts index c8c4515865052..3bf29e66baeb0 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName25.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName25.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { // No ASI [e] = 0 diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName27.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName27.ts index 8f917c77bf202..d52b7d43cfc94 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName27.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName27.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { // No ASI [e]: number = 0 diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName28.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName28.ts index a4bc0459ec9ee..2cae79f193465 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName28.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName28.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [e]: number = 0; [e2]: number diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName29.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName29.ts index 7961dc3493836..c3e42731ab99f 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName29.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName29.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { // yes ASI [e] = id++ diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName3.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName3.ts index 3a1b3a8de5567..0988e19a1ef02 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName3.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName3.ts @@ -1,3 +1,2 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var v = { [e]() { } }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName31.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName31.ts index 4f12dca90ee1d..30e511fa91b85 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName31.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName31.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { // yes ASI [e]: number diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName32.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName32.ts index 76d4c26e15317..f1a50fe108d67 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName32.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName32.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC declare class C { [e](): number } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName33.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName33.ts index 472621d53b6ee..2ca7ac84af70d 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName33.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName33.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { // No ASI [e] = 0 diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName36.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName36.ts index 900e20cc9865a..62f5e3404533a 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName36.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName36.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [public ]: string; } \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName37.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName37.ts index 1eac443f2ef57..3af8e29c66670 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName37.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName37.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [public]: 0 }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName38.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName38.ts index d1bda6cf47f0e..21d13e569ddb2 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName38.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName38.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 class C { [public]() { } diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName39.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName39.ts index 2ab65bba6a823..af56d4d23fe41 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName39.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName39.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 "use strict"; class C { diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName4.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName4.ts index 1d3a0beb6f3e1..e36773105fe7b 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName4.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName4.ts @@ -1,3 +1,2 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var v = { get [e]() { } }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName5.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName5.ts index 533c30327f529..869f340929b82 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName5.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName5.ts @@ -1,3 +1,2 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 var v = { public get [e]() { } }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName6.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName6.ts index f04772c9b62e8..aaf4131d1580f 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName6.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName6.ts @@ -1,3 +1,2 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC var v = { [e]: 1, [e + e]: 2 }; \ No newline at end of file diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName7.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName7.ts index e6a5f6b46c3bd..8f918c6116049 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName7.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName7.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 class C { [e] diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName8.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName8.ts index 8e9fd09e9ab77..6e55c04b7a17c 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName8.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName8.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES6 class C { public [e] diff --git a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName9.ts b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName9.ts index a9fe9f135e51e..0c60d35fb909a 100644 --- a/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName9.ts +++ b/tests/cases/conformance/parser/ecmascript6/ComputedPropertyNames/parserComputedPropertyName9.ts @@ -1,5 +1,4 @@ //@target: ES6 -//@isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC class C { [e]: Type } \ No newline at end of file diff --git a/tests/cases/conformance/pedantic/noUncheckedIndexedAccess.ts b/tests/cases/conformance/pedantic/noUncheckedIndexedAccess.ts index 91a5401f8a0ad..a07324f834892 100644 --- a/tests/cases/conformance/pedantic/noUncheckedIndexedAccess.ts +++ b/tests/cases/conformance/pedantic/noUncheckedIndexedAccess.ts @@ -1,6 +1,5 @@ // @strict: true // @noUncheckedIndexedAccess: true -// @isolatedDeclarationDiffReason: TS normalizes types type CheckBooleanOnly = any; // Validate CheckBooleanOnly works - should error diff --git a/tests/cases/conformance/salsa/typeFromPropertyAssignment32.ts b/tests/cases/conformance/salsa/typeFromPropertyAssignment32.ts index f58616ff48eb0..498aa151e7306 100644 --- a/tests/cases/conformance/salsa/typeFromPropertyAssignment32.ts +++ b/tests/cases/conformance/salsa/typeFromPropertyAssignment32.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Property is defined in another file. DTE can't detect this but TSC has another error for this already // @Filename: expando.ts function ExpandoMerge(n: number) { return n; diff --git a/tests/cases/conformance/salsa/typeFromPropertyAssignment33.ts b/tests/cases/conformance/salsa/typeFromPropertyAssignment33.ts index d3e95d9a9b2c6..d98f689329dd3 100644 --- a/tests/cases/conformance/salsa/typeFromPropertyAssignment33.ts +++ b/tests/cases/conformance/salsa/typeFromPropertyAssignment33.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Property is defined in another file. DTE can't detect this but TSC has another error for this already // @Filename: ns.ts namespace ExpandoMerge { export var p3 = 333; diff --git a/tests/cases/conformance/statements/for-ofStatements/ES5For-ofTypeCheck10.ts b/tests/cases/conformance/statements/for-ofStatements/ES5For-ofTypeCheck10.ts index ac1091044d404..b832d57855ed2 100644 --- a/tests/cases/conformance/statements/for-ofStatements/ES5For-ofTypeCheck10.ts +++ b/tests/cases/conformance/statements/for-ofStatements/ES5For-ofTypeCheck10.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: Invalid computed property can only be detected by TSC //@target: ES5 // In ES3/5, you cannot for...of over an arbitrary iterable. diff --git a/tests/cases/conformance/types/literal/literalTypesAndTypeAssertions.ts b/tests/cases/conformance/types/literal/literalTypesAndTypeAssertions.ts index 692ca1f1ed14e..5c11dd91035e8 100644 --- a/tests/cases/conformance/types/literal/literalTypesAndTypeAssertions.ts +++ b/tests/cases/conformance/types/literal/literalTypesAndTypeAssertions.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types const obj = { a: "foo" as "foo", b: <"foo">"foo", diff --git a/tests/cases/conformance/types/literal/stringLiteralsWithTypeAssertions01.ts b/tests/cases/conformance/types/literal/stringLiteralsWithTypeAssertions01.ts index e590e0570f332..2e3542704129d 100644 --- a/tests/cases/conformance/types/literal/stringLiteralsWithTypeAssertions01.ts +++ b/tests/cases/conformance/types/literal/stringLiteralsWithTypeAssertions01.ts @@ -1,5 +1,4 @@ -// @isolatedDeclarationDiffReason: TS normalizes types -let fooOrBar: "foo" | "bar"; +let fooOrBar: "foo" | "bar"; let a = "foo" as "bar"; let b = "bar" as "foo"; diff --git a/tests/cases/conformance/types/specifyingTypes/typeQueries/recursiveTypesWithTypeof.ts b/tests/cases/conformance/types/specifyingTypes/typeQueries/recursiveTypesWithTypeof.ts index d1e3ce2b798f4..b39d9dd53a8fd 100644 --- a/tests/cases/conformance/types/specifyingTypes/typeQueries/recursiveTypesWithTypeof.ts +++ b/tests/cases/conformance/types/specifyingTypes/typeQueries/recursiveTypesWithTypeof.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS normalizes types // The following are errors because of circular references var c: typeof c; var c: any; diff --git a/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument.ts b/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument.ts index aedab63711a19..86f6df5cdfe3d 100644 --- a/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument.ts +++ b/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS resolves types // it is an error to use a generic type without type arguments // all of these are errors diff --git a/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument2.ts b/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument2.ts index 2a7d99d9fde0c..7f062766cb3b5 100644 --- a/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument2.ts +++ b/tests/cases/conformance/types/specifyingTypes/typeReferences/genericTypeReferenceWithoutTypeArgument2.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS resolves types // it is an error to use a generic type without type arguments // all of these are errors diff --git a/tests/cases/conformance/types/thisType/thisTypeErrors.ts b/tests/cases/conformance/types/thisType/thisTypeErrors.ts index b1b99832b8dd5..a7e4a46493d05 100644 --- a/tests/cases/conformance/types/thisType/thisTypeErrors.ts +++ b/tests/cases/conformance/types/thisType/thisTypeErrors.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS resolves invalid types to any var x1: this; var x2: { a: this }; var x3: this[]; diff --git a/tests/cases/conformance/types/thisType/thisTypeInAccessors.ts b/tests/cases/conformance/types/thisType/thisTypeInAccessors.ts index aa4d5c0509f75..b09037597671e 100644 --- a/tests/cases/conformance/types/thisType/thisTypeInAccessors.ts +++ b/tests/cases/conformance/types/thisType/thisTypeInAccessors.ts @@ -1,7 +1,6 @@ // @noImplicitAny: true // @noImplicitThis: true // @target: es5 -// @isolatedDeclarationDiffReason: TS merges accessors with the same type. DTE can only merge if one type is specified. interface Foo { n: number; x: number; diff --git a/tests/cases/conformance/types/typeRelationships/typeInference/contextualSignatureInstantiation.ts b/tests/cases/conformance/types/typeRelationships/typeInference/contextualSignatureInstantiation.ts index d708a389ba03d..30c6579dabb07 100644 --- a/tests/cases/conformance/types/typeRelationships/typeInference/contextualSignatureInstantiation.ts +++ b/tests/cases/conformance/types/typeRelationships/typeInference/contextualSignatureInstantiation.ts @@ -1,4 +1,3 @@ -// @isolatedDeclarationDiffReason: TS changes the order of union constituents // TypeScript Spec, section 4.12.2: // If e is an expression of a function type that contains exactly one generic call signature and no other members, // and T is a function type with exactly one non - generic call signature and no other members, then any inferences From 373aaf44140eaa31485653a655201a2293c755e9 Mon Sep 17 00:00:00 2001 From: Titian Cernicova-Dragomir Date: Wed, 17 Jan 2024 13:07:52 +0000 Subject: [PATCH 2/3] Made test names more consistent. Signed-off-by: Titian Cernicova-Dragomir --- src/testRunner/compilerRunner.ts | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/testRunner/compilerRunner.ts b/src/testRunner/compilerRunner.ts index c2a01ad0c6b0a..3e776ec8e171e 100644 --- a/src/testRunner/compilerRunner.ts +++ b/src/testRunner/compilerRunner.ts @@ -127,8 +127,8 @@ export class CompilerBaselineRunner extends RunnerBase { }); it(`Correct dte emit for ${fileName}`, () => isolatedTest?.verifyDteOutput()); it(`Correct tsc emit for ${fileName}`, () => isolatedTest?.verifyTscOutput()); - it(`Correct dte/tsc diff ${fileName}`, () => isolatedTest?.verifyDiff()); - it(`Correct diff reason ${fileName}`, () => isolatedTest?.verifyDiffReason()); + it(`Correct dte/tsc diff for ${fileName}`, () => isolatedTest?.verifyDiff()); + it(`Correct diff reason for ${fileName}`, () => isolatedTest?.verifyDiffReason()); after(() => { isolatedTest = undefined!; @@ -142,18 +142,17 @@ export class CompilerBaselineRunner extends RunnerBase { if (fixedIsolatedTestEnv) { fixedIsolatedTest = new FixedIsolatedDeclarationTest(fixedIsolatedTestEnv); } - else if(!environment.compilerOptions.isolatedDeclarationDiffReason) { - // Don't skip if they have a reason we need to fail if unused reasons exist + else { this.skip(); } }); - it(`Correct dte emit for ${fileName}`, () => fixedIsolatedTest?.verifyDteOutput()); - it(`Correct tsc emit for ${fileName}`, () => fixedIsolatedTest?.verifyTscOutput()); - it(`Correct dte/tsc diff ${fileName}`, () => fixedIsolatedTest?.verifyDiff()); - it(`Correct dte map emit for ${fileName}`, () => fixedIsolatedTest?.verifyDteMapOutput()); - it(`Correct tsc map emit for ${fileName}`, () => fixedIsolatedTest?.verifyTscMapOutput()); - it(`Correct dte/tsc map diff ${fileName}`, () => fixedIsolatedTest?.verifyMapDiff()); - it(`Correct diff reason ${fileName}`, () => fixedIsolatedTest?.verifyDiffReason()); + it(`Correct dte emit for fixed ${fileName}`, () => fixedIsolatedTest?.verifyDteOutput()); + it(`Correct tsc emit for fixed ${fileName}`, () => fixedIsolatedTest?.verifyTscOutput()); + it(`Correct dte/tsc diff for fixed ${fileName}`, () => fixedIsolatedTest?.verifyDiff()); + it(`Correct dte map emit for fixed ${fileName}`, () => fixedIsolatedTest?.verifyDteMapOutput()); + it(`Correct tsc map emit for fixed ${fileName}`, () => fixedIsolatedTest?.verifyTscMapOutput()); + it(`Correct dte/tsc map diff for fixed ${fileName}`, () => fixedIsolatedTest?.verifyMapDiff()); + it(`Correct diff reason for fixed ${fileName}`, () => fixedIsolatedTest?.verifyDiffReason()); after(() => { fixedIsolatedTest = undefined!; From e7ad116cd40c35b292206140fd2a211e17f0c807 Mon Sep 17 00:00:00 2001 From: Titian Cernicova-Dragomir Date: Wed, 17 Jan 2024 15:07:49 +0000 Subject: [PATCH 3/3] Fixed formatting. Signed-off-by: Titian Cernicova-Dragomir --- src/testRunner/compilerRunner.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/testRunner/compilerRunner.ts b/src/testRunner/compilerRunner.ts index 3e776ec8e171e..96236d2dfb9d8 100644 --- a/src/testRunner/compilerRunner.ts +++ b/src/testRunner/compilerRunner.ts @@ -488,7 +488,7 @@ class IsolatedDeclarationTest extends CompilerTestBase { // Exclude tests some tests // - those explicitly not opting into isolatedDeclarations // - those that do not usually emit output anyway - if((options.isolatedDeclarations === false || options.noEmit || options.noTypesAndSymbols || !options.declaration)) { + if (options.isolatedDeclarations === false || options.noEmit || options.noTypesAndSymbols || !options.declaration) { return undefined; } } @@ -665,7 +665,8 @@ class IsolatedDeclarationTest extends CompilerTestBase { verifyDiffReason() { if (this.isOutputMapEquivalent && this.isOutputEquivalent && this.isDiagnosticEquivalent) { ts.Debug.assert(this.diffReason === undefined, "Should not have a diff reason if everything is equivalent"); - }else { + } + else { ts.Debug.assert(this.diffReason !== undefined, "Should have a reason if everything is not equivalent"); } } @@ -706,7 +707,7 @@ class IsolatedDeclarationTest extends CompilerTestBase { class FixedIsolatedDeclarationTest extends IsolatedDeclarationTest { static fixTestProject(compilerEnvironment: CompilerTestEnvironment, shouldNotExclude = !!compilerEnvironment.testCaseContent.settings.isolatedDeclarationFixedDiffReason): CompilerTestEnvironment | undefined { - if(!shouldNotExclude) { + if (!shouldNotExclude) { // Exclude test that disable types and symbols (good proxy for very complex test) if (compilerEnvironment.compilerOptions.noTypesAndSymbols) { return undefined;