private name tests strict+es6

Update private name tests to use 'strict'
type checking and to target es6 instead of
default. Makes the js output easier to read
and tests more surface area with other
checker features.

Signed-off-by: Max Heiber <[email protected]>

Author: mheiber

tests/baselines/reference/privateNameAndIndexSignature.errors.txt

@@ -1,7 +1,9 @@
-tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts(4,14): error TS2339: Property '#f' does not exist on type 'A'.
+tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts(6,14): error TS2339: Property '#f' does not exist on type 'A'.
 
 
 ==== tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts (1 errors) ====
+    // @target es6
+    
     class A {
         [k: string]: any;
         constructor(message: string) {

tests/baselines/reference/privateNameAndIndexSignature.js

@@ -1,4 +1,6 @@
 //// [privateNameAndIndexSignature.ts]
+// @target es6
+
 class A {
     [k: string]: any;
     constructor(message: string) {
@@ -8,6 +10,8 @@ class A {
 
 
 //// [privateNameAndIndexSignature.js]
+"use strict";
+// @target es6
 var A = /** @class */ (function () {
     function A(message) {
         this.#f = 3; // Error Property '#f' does not exist on type 'A'.

tests/baselines/reference/privateNameAndIndexSignature.symbols

@@ -1,12 +1,14 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts ===
+// @target es6
+
 class A {
 >A : Symbol(A, Decl(privateNameAndIndexSignature.ts, 0, 0))
 
     [k: string]: any;
->k : Symbol(k, Decl(privateNameAndIndexSignature.ts, 1, 5))
+>k : Symbol(k, Decl(privateNameAndIndexSignature.ts, 3, 5))
 
     constructor(message: string) {
->message : Symbol(message, Decl(privateNameAndIndexSignature.ts, 2, 16))
+>message : Symbol(message, Decl(privateNameAndIndexSignature.ts, 4, 16))
 
         this.#f = 3                 // Error Property '#f' does not exist on type 'A'.
 >this : Symbol(A, Decl(privateNameAndIndexSignature.ts, 0, 0))

tests/baselines/reference/privateNameAndIndexSignature.types

@@ -1,4 +1,6 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts ===
+// @target es6
+
 class A {
 >A : A
 

tests/baselines/reference/privateNameConstructorReserved.errors.txt

@@ -1,7 +1,9 @@
-tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts(2,5): error TS18006: '#constructor' is a reserved word.
+tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts(4,5): error TS18006: '#constructor' is a reserved word.
 
 
 ==== tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts (1 errors) ====
+    // @target es6
+    
     class A {
         #constructor() {}      // Error: `#constructor` is a reserved word.
         ~~~~~~~~~~~~

tests/baselines/reference/privateNameConstructorReserved.js

@@ -1,10 +1,13 @@
 //// [privateNameConstructorReserved.ts]
+// @target es6
+
 class A {
     #constructor() {}      // Error: `#constructor` is a reserved word.
 }
 
 
 //// [privateNameConstructorReserved.js]
+// @target es6
 var A = /** @class */ (function () {
     function A() {
     }

tests/baselines/reference/privateNameConstructorReserved.symbols

@@ -1,8 +1,10 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts ===
+// @target es6
+
 class A {
 >A : Symbol(A, Decl(privateNameConstructorReserved.ts, 0, 0))
 
     #constructor() {}      // Error: `#constructor` is a reserved word.
->#constructor : Symbol(A[#constructor], Decl(privateNameConstructorReserved.ts, 0, 9))
+>#constructor : Symbol(A[#constructor], Decl(privateNameConstructorReserved.ts, 2, 9))
 }
 

tests/baselines/reference/privateNameConstructorReserved.types

@@ -1,4 +1,6 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts ===
+// @target es6
+
 class A {
 >A : A
 

tests/baselines/reference/privateNameDuplicateField.errors.txt

@@ -1,10 +1,12 @@
-tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts(3,5): error TS2300: Duplicate identifier '#foo'.
+tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts(5,5): error TS2300: Duplicate identifier '#foo'.
 
 
 ==== tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts (1 errors) ====
+    // @target es6
+    
     class A {
-        #foo;
-        #foo;
+        #foo = "foo";
+        #foo = "foo";
         ~~~~
 !!! error TS2300: Duplicate identifier '#foo'.
     }

tests/baselines/reference/privateNameDuplicateField.js

@@ -1,13 +1,19 @@
 //// [privateNameDuplicateField.ts]
+// @target es6
+
 class A {
-    #foo;
-    #foo;
+    #foo = "foo";
+    #foo = "foo";
 }
 
 
 //// [privateNameDuplicateField.js]
+"use strict";
+// @target es6
 var A = /** @class */ (function () {
     function A() {
+        this.#foo = "foo";
+        this.#foo = "foo";
     }
     return A;
 }());

tests/baselines/reference/privateNameDuplicateField.symbols

@@ -1,11 +1,13 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts ===
+// @target es6
+
 class A {
 >A : Symbol(A, Decl(privateNameDuplicateField.ts, 0, 0))
 
-    #foo;
->#foo : Symbol(A[#foo], Decl(privateNameDuplicateField.ts, 0, 9), Decl(privateNameDuplicateField.ts, 1, 9))
+    #foo = "foo";
+>#foo : Symbol(A[#foo], Decl(privateNameDuplicateField.ts, 2, 9), Decl(privateNameDuplicateField.ts, 3, 17))
 
-    #foo;
->#foo : Symbol(A[#foo], Decl(privateNameDuplicateField.ts, 0, 9), Decl(privateNameDuplicateField.ts, 1, 9))
+    #foo = "foo";
+>#foo : Symbol(A[#foo], Decl(privateNameDuplicateField.ts, 2, 9), Decl(privateNameDuplicateField.ts, 3, 17))
 }
 

tests/baselines/reference/privateNameDuplicateField.types

@@ -1,11 +1,15 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts ===
+// @target es6
+
 class A {
 >A : A
 
-    #foo;
->#foo : any
+    #foo = "foo";
+>#foo : string
+>"foo" : "foo"
 
-    #foo;
->#foo : any
+    #foo = "foo";
+>#foo : string
+>"foo" : "foo"
 }
 

tests/baselines/reference/privateNameField.js

@@ -1,4 +1,6 @@
 //// [privateNameField.ts]
+// @target es6
+
 class A {
     #name: string;
     constructor(name: string) {
@@ -7,13 +9,11 @@ class A {
 }
 
 //// [privateNameField.js]
-var _classPrivateFieldSet = function (receiver, privateMap, value) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to set private field on non-instance"); } privateMap.set(receiver, value); return value; };
-var _name;
+"use strict";
+// @target es6
 var A = /** @class */ (function () {
     function A(name) {
-        _name.set(this, void 0);
-        _classPrivateFieldSet(this, _name, name);
+        this.#name = name;
     }
     return A;
 }());
-_name = new WeakMap();

tests/baselines/reference/privateNameField.symbols

@@ -1,16 +1,18 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameField.ts ===
+// @target es6
+
 class A {
 >A : Symbol(A, Decl(privateNameField.ts, 0, 0))
 
     #name: string;
->#name : Symbol(A.#name, Decl(privateNameField.ts, 0, 9))
+>#name : Symbol(A[#name], Decl(privateNameField.ts, 2, 9))
 
     constructor(name: string) {
->name : Symbol(name, Decl(privateNameField.ts, 2, 16))
+>name : Symbol(name, Decl(privateNameField.ts, 4, 16))
 
         this.#name = name;
->this.#name : Symbol(A.#name, Decl(privateNameField.ts, 0, 9))
+>this.#name : Symbol(A[#name], Decl(privateNameField.ts, 2, 9))
 >this : Symbol(A, Decl(privateNameField.ts, 0, 0))
->name : Symbol(name, Decl(privateNameField.ts, 2, 16))
+>name : Symbol(name, Decl(privateNameField.ts, 4, 16))
     }
 }

tests/baselines/reference/privateNameField.types

@@ -1,4 +1,6 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameField.ts ===
+// @target es6
+
 class A {
 >A : A
 

tests/baselines/reference/privateNameNotAccessibleOutsideDefiningClass.errors.txt

@@ -1,8 +1,10 @@
-tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts(5,9): error TS2339: Property '#foo' does not exist on type 'A'.
-tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts(5,9): error TS18007: Property '#foo' is not accessible outside class 'A' because it has a private name.
+tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts(7,9): error TS2339: Property '#foo' does not exist on type 'A'.
+tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts(7,9): error TS18007: Property '#foo' is not accessible outside class 'A' because it has a private name.
 
 
 ==== tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts (2 errors) ====
+    // @target es6
+    
     class A {
         #foo: number = 3;
     }

tests/baselines/reference/privateNameNotAccessibleOutsideDefiningClass.js

@@ -1,4 +1,6 @@
 //// [privateNameNotAccessibleOutsideDefiningClass.ts]
+// @target es6
+
 class A {
     #foo: number = 3;
 }
@@ -7,6 +9,8 @@ new A().#foo = 4;               // Error
 
 
 //// [privateNameNotAccessibleOutsideDefiningClass.js]
+"use strict";
+// @target es6
 var A = /** @class */ (function () {
     function A() {
         this.#foo = 3;

tests/baselines/reference/privateNameNotAccessibleOutsideDefiningClass.symbols

@@ -1,9 +1,11 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts ===
+// @target es6
+
 class A {
 >A : Symbol(A, Decl(privateNameNotAccessibleOutsideDefiningClass.ts, 0, 0))
 
     #foo: number = 3;
->#foo : Symbol(A[#foo], Decl(privateNameNotAccessibleOutsideDefiningClass.ts, 0, 9))
+>#foo : Symbol(A[#foo], Decl(privateNameNotAccessibleOutsideDefiningClass.ts, 2, 9))
 }
 
 new A().#foo = 4;               // Error

tests/baselines/reference/privateNameNotAccessibleOutsideDefiningClass.types

@@ -1,4 +1,6 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts ===
+// @target es6
+
 class A {
 >A : A
 

tests/baselines/reference/privateNameNotAllowedOutsideClass.errors.txt

@@ -1,9 +1,11 @@
-tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts(1,7): error TS1134: Variable declaration expected.
-tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts(1,12): error TS1134: Variable declaration expected.
-tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts(1,14): error TS1134: Variable declaration expected.
+tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts(3,7): error TS1134: Variable declaration expected.
+tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts(3,12): error TS1134: Variable declaration expected.
+tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts(3,14): error TS1134: Variable declaration expected.
 
 
 ==== tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts (3 errors) ====
+    // @target es6
+    
     const #foo = 3;
           ~~~~
 !!! error TS1134: Variable declaration expected.

tests/baselines/reference/privateNameNotAllowedOutsideClass.js

@@ -1,6 +1,10 @@
 //// [privateNameNotAllowedOutsideClass.ts]
+// @target es6
+
 const #foo = 3;
 
 //// [privateNameNotAllowedOutsideClass.js]
+"use strict";
+// @target es6
 var ;
 3;

tests/baselines/reference/privateNameNotAllowedOutsideClass.symbols

@@ -1,3 +1,5 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts ===
-const #foo = 3;
+// @target es6
+No type information for this code.
+No type information for this code.const #foo = 3;
 No type information for this code.

tests/baselines/reference/privateNameNotAllowedOutsideClass.types

@@ -1,4 +1,6 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameNotAllowedOutsideClass.ts ===
+// @target es6
+
 const #foo = 3;
 >3 : 3
 

tests/baselines/reference/privateNameSneakyRuntimeException.js

@@ -1,8 +1,10 @@
 //// [privateNameSneakyRuntimeException.ts]
+// @target es6
+
 function createClass () {
     return class {
-        #foo;
-        equals(other) {
+        #foo = 3;
+        equals(other: any) {
             return this.#foo = other.#foo;
         }
     };
@@ -15,9 +17,12 @@ console.log(a.equals(b));     // OK at compile time but will be a runtime error
 
 
 //// [privateNameSneakyRuntimeException.js]
+"use strict";
+// @target es6
 function createClass() {
     return /** @class */ (function () {
         function class_1() {
+            this.#foo = 3;
         }
         class_1.prototype.equals = function (other) {
             return this.#foo = other.#foo;

tests/baselines/reference/privateNameSneakyRuntimeException.symbols

@@ -1,37 +1,39 @@
 === tests/cases/conformance/classes/members/privateNames/privateNameSneakyRuntimeException.ts ===
+// @target es6
+
 function createClass () {
 >createClass : Symbol(createClass, Decl(privateNameSneakyRuntimeException.ts, 0, 0))
 
     return class {
-        #foo;
->#foo : Symbol((Anonymous class)[#foo], Decl(privateNameSneakyRuntimeException.ts, 1, 18))
+        #foo = 3;
+>#foo : Symbol((Anonymous class)[#foo], Decl(privateNameSneakyRuntimeException.ts, 3, 18))
 
-        equals(other) {
->equals : Symbol((Anonymous class).equals, Decl(privateNameSneakyRuntimeException.ts, 2, 13))
->other : Symbol(other, Decl(privateNameSneakyRuntimeException.ts, 3, 15))
+        equals(other: any) {
+>equals : Symbol((Anonymous class).equals, Decl(privateNameSneakyRuntimeException.ts, 4, 17))
+>other : Symbol(other, Decl(privateNameSneakyRuntimeException.ts, 5, 15))
 
             return this.#foo = other.#foo;
->this.#foo : Symbol((Anonymous class)[#foo], Decl(privateNameSneakyRuntimeException.ts, 1, 18))
->this : Symbol((Anonymous class), Decl(privateNameSneakyRuntimeException.ts, 1, 10))
->other : Symbol(other, Decl(privateNameSneakyRuntimeException.ts, 3, 15))
+>this.#foo : Symbol((Anonymous class)[#foo], Decl(privateNameSneakyRuntimeException.ts, 3, 18))
+>this : Symbol((Anonymous class), Decl(privateNameSneakyRuntimeException.ts, 3, 10))
+>other : Symbol(other, Decl(privateNameSneakyRuntimeException.ts, 5, 15))
         }
     };
 }
 
 const a = new (createClass())();
->a : Symbol(a, Decl(privateNameSneakyRuntimeException.ts, 9, 5))
+>a : Symbol(a, Decl(privateNameSneakyRuntimeException.ts, 11, 5))
 >createClass : Symbol(createClass, Decl(privateNameSneakyRuntimeException.ts, 0, 0))
 
 const b = new (createClass())();
->b : Symbol(b, Decl(privateNameSneakyRuntimeException.ts, 10, 5))
+>b : Symbol(b, Decl(privateNameSneakyRuntimeException.ts, 12, 5))
 >createClass : Symbol(createClass, Decl(privateNameSneakyRuntimeException.ts, 0, 0))
 
 console.log(a.equals(b));     // OK at compile time but will be a runtime error
 >console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
 >console : Symbol(console, Decl(lib.dom.d.ts, --, --))
 >log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
->a.equals : Symbol((Anonymous class).equals, Decl(privateNameSneakyRuntimeException.ts, 2, 13))
->a : Symbol(a, Decl(privateNameSneakyRuntimeException.ts, 9, 5))
->equals : Symbol((Anonymous class).equals, Decl(privateNameSneakyRuntimeException.ts, 2, 13))
->b : Symbol(b, Decl(privateNameSneakyRuntimeException.ts, 10, 5))
+>a.equals : Symbol((Anonymous class).equals, Decl(privateNameSneakyRuntimeException.ts, 4, 17))
+>a : Symbol(a, Decl(privateNameSneakyRuntimeException.ts, 11, 5))
+>equals : Symbol((Anonymous class).equals, Decl(privateNameSneakyRuntimeException.ts, 4, 17))
+>b : Symbol(b, Decl(privateNameSneakyRuntimeException.ts, 12, 5))