Skip to content

Commit 5f53116

Browse files
committed
Improve the performance of isolatedDeclarations quickfix
It turns out that `typeChecker.getEmitResolver()` can be expensive, so avoid calling it unless necessary. Hopefully this fixes the performance issue (bullet microsoft#1) of microsoft#58426
1 parent 59e6620 commit 5f53116

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/services/codefixes/fixMissingTypeAnnotationOnExports.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,6 @@ function withContext<T>(
237237
const sourceFile: SourceFile = context.sourceFile;
238238
const program = context.program;
239239
const typeChecker: TypeChecker = program.getTypeChecker();
240-
const emitResolver = typeChecker.getEmitResolver();
241240
const scriptTarget = getEmitScriptTarget(program.getCompilerOptions());
242241
const importAdder = createImportAdder(context.sourceFile, context.program, context.preferences, context.host);
243242
const fixedNodes = new Set<Node>();
@@ -887,7 +886,7 @@ function withContext<T>(
887886
type = widenedType;
888887
}
889888

890-
if (isParameter(node) && emitResolver.requiresAddingImplicitUndefined(node)) {
889+
if (isParameter(node) && typeChecker.getEmitResolver().requiresAddingImplicitUndefined(node)) {
891890
type = typeChecker.getUnionType([typeChecker.getUndefinedType(), type], UnionReduction.None);
892891
}
893892
const flags = (

0 commit comments

Comments
 (0)