Fixes for issue 901 continued #910
Conversation
| if (input.value !== undefined && input.value !== witnessValue) throw new Error('Input didn\'t match witnessValue') | ||
| typeforce(types.Satoshi, witnessValue) | ||
| input.value = witnessValue | ||
| } |
There was a problem hiding this comment.
I think this side steps the call to fixMultisigOrder, which would remove any signatures from the array which aren't valid?
|
@dcousens ah, I see the confusion.. I just found the exact same issue as mine recently: #901 (comment) which is indeed related to the input.value not being present, but the fixMsOrder demonstrates how it can be a problem if you leave it until So my solution was #909, which means that signatures fail and aren't extracted IF the transaction, which was passed to TransactionBuilder.fromTransaction as inputs which have the input.value for segwit outputs. Ping @dakk since we are having identical issues. |
|
As discussed on Slack, we'll need to incorporate the second half of the complete fix for this problem in #909 |
|
I confirm it works now with my test case, excellent work |
@afk11 maybe this is what you intended in #909 ?
f4a83f8 is a follow up to #907 which was having issues locally