Skip to content

Conversation

@darosior
Copy link
Member

@darosior darosior commented Nov 25, 2025

The BIP 54 sigops limit was made a standardness rule in Bitcoin Core 30.0 with the merge of bitcoin/bitcoin#32521.

that makes this type of transaction non-standard should be widely adopted before this soft fork is
considered for activation.
Bitcoin Core version [30.0][Core 30.0] and later will not generate a block template including a
transaction that violates the signature operations limit introduced in this BIP.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transaction that violates the signature operations limit introduced in this BIP.
transaction that violates the signature operations limit introduced in this BIP (see https://github.com/bitcoin/bitcoin/pull/32521).

Do you think it would be useful to link to bitcoin/bitcoin#32521 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i thought about it but figured it was superfluous to link to implementation details.

Copy link
Member

@jonatack jonatack Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a rough threshold for "widely adopted" and, depending on what it is relative to current v30 adoption, should a mention about adoption remain for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what's a good threshold to give. Ideally all of them would be upgraded before activation, but you also do not want to give a too small minority of miners a veto power over consensus changes.

If something is to be kept it should apply to the whole section really, although the two most concerning items are the coinbase restriction and this one. I'm not sure. On the other hand having a whole section about miner forward compatibility sort of speaks for itself.

The BIP 54 sigops limit was made a standardness rules in Bitcoin Core 30.0.
@darosior darosior force-pushed the 2511_bip54_forward_compat branch from 8c526c0 to 1076d90 Compare November 25, 2025 19:03
@darosior
Copy link
Member Author

Rebased after #2015 was merged (thanks!).

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1076d90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants