miner: fix addPackageTxs unsigned integer overflow

ismaelsadeeq · ismaelsadeeq · commit b807dfcdc592 · 2025-09-24T17:10:51.000+02:00
diff --git a/src/node/miner.cpp b/src/node/miner.cpp
@@ -397,8 +397,8 @@ void BlockAssembler::addPackageTxs(int& nPackagesSelected, int& nDescendantsUpda
 
             ++nConsecutiveFailed;
 
-            if (nConsecutiveFailed > MAX_CONSECUTIVE_FAILURES && nBlockWeight >
-                    m_options.nBlockMaxWeight - BLOCK_FULL_ENOUGH_WEIGHT_DELTA) {
+            if (nConsecutiveFailed > MAX_CONSECUTIVE_FAILURES && nBlockWeight +
+                    BLOCK_FULL_ENOUGH_WEIGHT_DELTA > m_options.nBlockMaxWeight) {
                 // Give up if we're close to full and haven't succeeded in a while
                 break;
             }

Original file line number	Diff line number	Diff line change
`@@ -397,8 +397,8 @@ void BlockAssembler::addPackageTxs(int& nPackagesSelected, int& nDescendantsUpda`
`397`	`397`
`398`	`398`	`++nConsecutiveFailed;`
`399`	`399`
`400`		`- if (nConsecutiveFailed > MAX_CONSECUTIVE_FAILURES && nBlockWeight >`
`401`		`- m_options.nBlockMaxWeight - BLOCK_FULL_ENOUGH_WEIGHT_DELTA) {`
	`400`	`+ if (nConsecutiveFailed > MAX_CONSECUTIVE_FAILURES && nBlockWeight +`
	`401`	`+ BLOCK_FULL_ENOUGH_WEIGHT_DELTA > m_options.nBlockMaxWeight) {`
`402`	`402`	`// Give up if we're close to full and haven't succeeded in a while`
`403`	`403`	`break;`
`404`	`404`	`}`