Merge #255: Properly relinquish activeFocus on ValueInput when editing is finished

90fd65b qml: Give up focus on ValueInput when editing finished (jarolrod)
ef26265 qml: Make ValueInput a TextInput instead of a TextEdit (jarolrod)

Pull request description:

  On master, pressing `enter` while editing a setting that has a ValueInput does not properly relinquish focus from the ValueInput, still leaving it in an editing state. This fixes that by:

  a. Making ValueInput a [TextInput](https://doc.qt.io/qt-5/qml-qtquick-textinput.html#text-prop) instead of a [TextEdit](https://doc.qt.io/qt-5/qml-qtquick-textedit.html)
    - TextEdit allows for multi-line input, so an `enter` in this would add a new line, which we don't want. There is no use case for a ValueInput to be multiple lines, it should only be one. Additionally, this prevents `enter` from signaling that editing is finished
    - TextInput is specifically for single line input. This QML type also allows us to do necessary validations with a [validator](https://doc.qt.io/qt-5/qml-qtquick-textinput.html#validator-prop), [inputMask](https://doc.qt.io/qt-5/qml-qtquick-textinput.html#inputMask-prop), and signal what kind of keyboard we want with [inputMethodHints](https://doc.qt.io/qt-5/qml-qtquick-textinput.html#inputMethodHints-prop). Additionally, this allows for `enter` to signal that editing is finished.

  b. Relinquishing focus on the ValueInput itself, by forcing focus back to the parent Setting.

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/255)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/255)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/255)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/255)

ACKs for top commit:
  johnny9:
    ACK 90fd65b

Tree-SHA512: 6b2d40b9f715b05b239112835eb9078ce5637005bbea28888161179ac8ea9f736471b8e734542a90538e1bfca0c0c41de426954d311852534859cf51431d755f

Author: hebasto

src/qml/components/DeveloperOptions.qml

@@ -30,7 +30,10 @@ ColumnLayout {
         actionItem: ValueInput {
             parentState: dbcacheSetting.state
             description: optionsModel.dbcacheSizeMiB
-            onEditingFinished: optionsModel.dbcacheSizeMiB = parseInt(text)
+            onEditingFinished: {
+                optionsModel.dbcacheSizeMiB = parseInt(text)
+                dbcacheSetting.forceActiveFocus()
+            }
         }
         onClicked: loadedItem.forceActiveFocus()
     }
@@ -42,7 +45,10 @@ ColumnLayout {
         actionItem: ValueInput {
             parentState: parSetting.state
             description: optionsModel.scriptThreads
-            onEditingFinished: optionsModel.scriptThreads = parseInt(text)
+            onEditingFinished: {
+                optionsModel.scriptThreads = parseInt(text)
+                parSetting.forceActiveFocus()
+            }
         }
         onClicked: loadedItem.forceActiveFocus()
     }

src/qml/components/StorageSettings.qml

@@ -36,7 +36,10 @@ ColumnLayout {
         actionItem: ValueInput {
             parentState: pruneTargetSetting.state
             description: optionsModel.pruneSizeGB
-            onEditingFinished: optionsModel.pruneSizeGB = parseInt(text)
+            onEditingFinished: {
+                optionsModel.pruneSizeGB = parseInt(text)
+                pruneTargetSetting.forceActiveFocus()
+            }
         }
         onClicked: loadedItem.forceActiveFocus()
     }

src/qml/controls/ValueInput.qml

@@ -5,7 +5,7 @@
 import QtQuick 2.15
 import QtQuick.Controls 2.15
 
-TextEdit {
+TextInput {
     id: root
     required property string parentState
     property string description: ""
@@ -44,7 +44,7 @@ TextEdit {
     font.styleName: "Regular"
     font.pixelSize: root.descriptionSize
     color: root.textColor
-    text: description
+    text: root.description
     horizontalAlignment: Text.AlignRight
     wrapMode: Text.WordWrap