Skip to content

[Merged by Bors] - gate an import used only for a debug assert #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mockersf wants to merge 1 commit into from
Closed

[Merged by Bors] - gate an import used only for a debug assert #7165

mockersf wants to merge 1 commit into from

Conversation

@mockersf
Copy link
Member

@mockersf mockersf commented Jan 11, 2023

Objective

  • There is a warning when building in release:
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Solution

@mockersf mockersf added the C-Code-Quality A section of code that is hard to understand or change label Jan 11, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 11, 2023
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 11, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@mockersf
gate an import used only for a debug assert (#7165)
aa3dd14 
# Objective

- There is a warning when building in release:
```
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47
- Fix it

## Solution

- Gate the import
- repeat of #5320
@bors
Copy link
Contributor

bors bot commented Jan 11, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title gate an import used only for a debug assert [Merged by Bors] - gate an import used only for a debug assert Jan 11, 2023
@bors bors bot closed this Jan 11, 2023
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
gate an import used only for a debug assert (bevyengine#7165)
a77d614 
# Objective

- There is a warning when building in release:
```
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47
- Fix it

## Solution

- Gate the import
- repeat of bevyengine#5320
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
gate an import used only for a debug assert (bevyengine#7165)
cebd21a 
# Objective

- There is a warning when building in release:
```
warning: unused import: `bevy_ecs::system::Local`
 --> crates/bevy_render/src/extract_resource.rs:5:5
  |
5 | use bevy_ecs::system::Local;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
```
- It's used https://github.com/bevyengine/bevy/blob/59751d6e33d94eff6e1fc20c9ae155974b3860b1/crates/bevy_render/src/extract_resource.rs#L47
- Fix it

## Solution

- Gate the import
- repeat of bevyengine#5320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

+2 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@MinerSebas MinerSebas MinerSebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mockersf @alice-i-cecile @james7132 @IceSentry @MinerSebas