[Merged by Bors] - Use World helper methods for sending HierarchyEvents
#6921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
approved these changes
Dec 12, 2022
james7132
added
C-Code-Quality
Carter0
reviewed
Dec 12, 2022
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Dec 12, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
Contributor
|
Build failed: |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
Contributor
bors
bot
changed the title
World helper methods for sending HierarchyEvents World helper methods for sending HierarchyEvents
bors bot
pushed a commit
that referenced
this pull request
Dec 26, 2022
…ed (#7031) # Objective - Loading a gltf files prints many errors ``` ERROR bevy_ecs::world: Unable to send event `bevy_hierarchy::events::HierarchyEvent` Event must be added to the app with `add_event()` https://docs.rs/bevy/*/bevy/app/struct.App.html#method.add_event ``` - Loading a gltf file create a world for a scene where events are not registered. Executing hierarchy commands on that world should not print error ## Solution - Revert part of #6921 - don't use `world.send_event` / `world.send_event_batch` from commands
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
…6921) A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
…ed (bevyengine#7031) # Objective - Loading a gltf files prints many errors ``` ERROR bevy_ecs::world: Unable to send event `bevy_hierarchy::events::HierarchyEvent` Event must be added to the app with `add_event()` https://docs.rs/bevy/*/bevy/app/struct.App.html#method.add_event ``` - Loading a gltf file create a world for a scene where events are not registered. Executing hierarchy commands on that world should not print error ## Solution - Revert part of bevyengine#6921 - don't use `world.send_event` / `world.send_event_batch` from commands
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…6921) A code-quality PR Also cleans up the helper methods by just importing the `Event` type Co-authored-by: devil-ira <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ed (bevyengine#7031) # Objective - Loading a gltf files prints many errors ``` ERROR bevy_ecs::world: Unable to send event `bevy_hierarchy::events::HierarchyEvent` Event must be added to the app with `add_event()` https://docs.rs/bevy/*/bevy/app/struct.App.html#method.add_event ``` - Loading a gltf file create a world for a scene where events are not registered. Executing hierarchy commands on that world should not print error ## Solution - Revert part of bevyengine#6921 - don't use `world.send_event` / `world.send_event_batch` from commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A code-quality PR
Also cleans up the helper methods by just importing the
Eventtype