use [Type]::new() constructor instead of new-object

Author: bergmeister

ScriptRuleDocumentation.md

@@ -70,9 +70,9 @@ Optionally, since version 1.17.0, a `SuggestedCorrections` property of type `IEn
 [string]$correction = 'Correct text that replaces Extent text'
 [string]$file = $MyInvocation.MyCommand.Definition
 [string]$optionalDescription = 'Useful but optional description text'
-$correctionExtent = New-Object 'Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent' $startLineNumber,$endLineNumber,$startColumnNumber,$endColumnNumber,$correction,$description
-$suggestedCorrections = New-Object System.Collections.ObjectModel.Collection['Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent']
-$suggestedCorrections.add($correctionExtent) | out-null
+$correctionExtent = [Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent]::new($startLineNumber,$endLineNumber,$startColumnNumber,$endColumnNumber,$correction,$description)
+$suggestedCorrections = [System.Collections.ObjectModel.Collection['Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent']]::new()
+$suggestedCorrections.Add($correctionExtent)
 
 [Microsoft.Windows.Powershell.ScriptAnalyzer.Generic.DiagnosticRecord]@{
     "Message"              = "This is a rule with a suggested correction"

Tests/Engine/samplerule/samplerule.psm1

@@ -28,12 +28,16 @@ function Measure-RequiresRunAsAdministrator
         [System.Management.Automation.Language.ScriptBlockAst]
         $testAst
     )        
-    $l=(new-object System.Collections.ObjectModel.Collection["Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent"])
-    $c = (new-object Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent 1,2,3,4,'text','filePath','description')
-    $l.Add($c)
-    $dr = New-Object `
-            -Typename "Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord" `
-            -ArgumentList "This is help",$ast.Extent,$PSCmdlet.MyInvocation.InvocationName,Warning,$null,$null,$l     
-        return $dr
+    $correctionExtentList = [System.Collections.ObjectModel.Collection[Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent]]::new()
+    $correctionExtent = [Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.CorrectionExtent]::new(1,2,3,4,'text','filePath','description')
+    $correctionExtentList.Add($correctionExtent)
+    $diagnosticRecord = [Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord]::new(
+        "This is help", 
+        $ast.Extent,$PSCmdlet.MyInvocation.InvocationName,
+        "Warning",
+        $null,
+        $null,
+        $correctionExtentList)
+    return $diagnosticRecord
 }
 Export-ModuleMember -Function Measure*