add environment detection tests and fix cache issue

Author: jaredcnance

src/environment/EnvironmentDetector.ts

@@ -64,18 +64,17 @@ const discoverEnvironment = async (): Promise<IEnvironment> => {
 }
 
 const _resolveEnvironment: EnvironmentProvider = async (): Promise<IEnvironment> => {
-  console.log('resolvingenvion')
   if (environment) {
     return environment;
   }
 
-  let detectedEnvironment = undefined;
   if (config.environmentOverride) {
-    detectedEnvironment = getEnvironmentFromOverride();
+    LOG("Environment override supplied", config.environmentOverride);
+    environment = getEnvironmentFromOverride();
+    return environment;
   }
 
-  detectedEnvironment = await discoverEnvironment();
-  environment = detectedEnvironment;  // eslint-disable-line require-atomic-updates
+  environment = await discoverEnvironment(); // eslint-disable-line require-atomic-updates
   return environment;
 };
 

src/environment/__tests__/EnvironmentDetector.test.ts

@@ -1,5 +1,7 @@
 import * as faker from 'faker';
 import { cleanResolveEnvironment } from '../EnvironmentDetector';
+import config from '../../config/Configuration';
+import Environments from '../Environments';
 
 beforeEach(() => {
   process.env = {};
@@ -24,3 +26,14 @@ test('resolveEnvironment() returns DefaultEnvironment if nothing else was detect
   // assert
   expect(result.constructor.name).toBe('DefaultEnvironment');
 }, 10000);
+
+test('resolveEnvironment() honors configured override', async () => {
+  // arrange
+  config.environmentOverride = Environments.Local;
+
+  // act
+  const result = await cleanResolveEnvironment();
+
+  // assert
+  expect(result.constructor.name).toBe('LocalEnvironment');
+});