Java V2 Add examples for Control Tower #7668
Conversation
scmacdon
added
Java-v2
scmacdon
changed the title
| excerpts: | ||
| - description: | ||
| snippet_tags: | ||
| - controltower.java2.list_landing_zones.main |
| do { | ||
| ListLandingZonesRequest.Builder requestBuilder = ListLandingZonesRequest.builder(); | ||
| if (nextToken != null) { | ||
| requestBuilder.nextToken(nextToken); |
There was a problem hiding this comment.
This code should use the paginator.
| return baselines; | ||
|
|
||
| } catch (ControlTowerException e) { | ||
| String errorCode = e.awsErrorDetails().errorCode(); |
There was a problem hiding this comment.
This exception code looks different from the established patterns in the rest of the Java examples. It looks too similar to the .NET code, are you sure it is correct? Same question for all of the exception handlers.
| String nextToken = null; | ||
|
|
||
| do { | ||
| ListEnabledBaselinesRequest.Builder requestBuilder = ListEnabledBaselinesRequest.builder(); |
There was a problem hiding this comment.
Code should use the paginator.
|
|
||
| try { | ||
|
|
||
| ControlTowerClient controlTowerClient = ControlTowerClient.builder() |
There was a problem hiding this comment.
Is the Java code not using async operations any more?
| waitForInputToContinue(scanner); | ||
| /* | ||
| logger.info(DASHES); |
| */ | ||
| } catch (ControlTowerException e) { |
There was a problem hiding this comment.
Where is the rest of the scenario? The specification includes a lot more than just listing enabled baselines. See the sections on Baselines and the sections on Controls in the specification here: https://github.com/awsdocs/aws-doc-sdk-examples/blob/main/scenarios/basics/controltower/SPECIFICATION.md
| public static void main(String[] args) { | ||
| try { | ||
| ControlTowerClient controlTowerClient = ControlTowerClient.builder() | ||
| .region(Region.US_EAST_1) |
| @@ -0,0 +1,3 @@ | |||
| dataAccessRoleArn = <enter data access role ARN> | |||
There was a problem hiding this comment.
What does this file have to do with the scenario? DocumentClassifier?
| * @throws ControlTowerException if a service-specific error occurs | ||
| * @throws SdkException if an SDK error occurs | ||
| */ | ||
| public static BaselineOperationStatus getBaselineOperation(ControlTowerClient controlTowerClient, |
There was a problem hiding this comment.
These methods are never called by the scenario?
2 participants
This pull request adds Java V2 examples for Control Tower.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.