Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Sep 24, 2025

Problem

There are compilation errors on this branch after auto merges

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.ts:185:76 - error TS2339: Property '$response' does not exist on type 'SendTelemetryEventCommandOutput'.

185             this.logging.log(`SendTelemetryEvent succeeded, requestId: ${r.$response.requestId}`)
                                                                               ~~~~~~~~~

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.ts:650:54 - error TS2304: Cannot find name 'AgenticChatEventStatus'.

650             result: (params.result?.toUpperCase() ?? AgenticChatEventStatus.Succeeded) as AgenticChatEventStatus,
                                                         ~~~~~~~~~~~~~~~~~~~~~~

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.ts:650:91 - error TS2304: Cannot find name 'AgenticChatEventStatus'.

650             result: (params.result?.toUpperCase() ?? AgenticChatEventStatus.Succeeded) as AgenticChatEventStatus,
                                                                                              ~~~~~~~~~~~~~~~~~~~~~~

Solution

Fix compilation errors

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ctlai95 ctlai95 marked this pull request as ready for review September 24, 2025 19:43
@ctlai95 ctlai95 requested a review from a team as a code owner September 24, 2025 19:43
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.78%. Comparing base (a1d1f54) to head (9408655).
⚠️ Report is 23 commits behind head on feature/v2-to-v3-migration.

Files with missing lines Patch % Lines
...whisperer/src/shared/telemetry/telemetryService.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/v2-to-v3-migration    #2331      +/-   ##
==============================================================
- Coverage                       60.22%   59.78%   -0.44%     
==============================================================
  Files                             256      258       +2     
  Lines                           57081    58263    +1182     
  Branches                         3507     3555      +48     
==============================================================
+ Hits                            34376    34834     +458     
- Misses                          22639    23363     +724     
  Partials                           66       66              
Flag Coverage Δ
unittests 59.78% <50.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ctlai95 ctlai95 merged commit 9689fd2 into aws:feature/v2-to-v3-migration Sep 24, 2025
8 of 9 checks passed
@ctlai95 ctlai95 deleted the fix-compile-error branch September 24, 2025 21:04
chungjac added a commit that referenced this pull request Oct 7, 2025
* feat: migrate codewhisperer token service to aws-sdk-v3 (#2235)

* feat: migrate codewhisperer token service to aws-sdk-v3

* fix captureHeaders middleware

* feat: migrate codewhisperer iam service to aws-sdk-v3 (#2284)

* refactor: remove aws-sdk v2 imports (#2290)

* fix: compile errors from merge conflicts (#2331)

* chore: bump runtimes to 0.3.0 (#2340)

* chore: bump runtimes to 0.3.0

* fix antlr4ng version conflict

* fix missing url polyfill

* chore: remove old ignore entries (#2350)

---------

Co-authored-by: aws-toolkit-automation <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
chungjac added a commit that referenced this pull request Oct 7, 2025
* feat: migrate codewhisperer token service to aws-sdk-v3 (#2235)

* feat: migrate codewhisperer token service to aws-sdk-v3

* fix captureHeaders middleware

* feat: migrate codewhisperer iam service to aws-sdk-v3 (#2284)

* refactor: remove aws-sdk v2 imports (#2290)

* fix: compile errors from merge conflicts (#2331)

* chore: bump runtimes to 0.3.0 (#2340)

* chore: bump runtimes to 0.3.0

* fix antlr4ng version conflict

* fix missing url polyfill

* chore: remove old ignore entries (#2350)

---------

Co-authored-by: aws-toolkit-automation <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
chungjac added a commit that referenced this pull request Oct 10, 2025
* feat: migrate codewhisperer token service to aws-sdk-v3 (#2235)

* feat: migrate codewhisperer token service to aws-sdk-v3

* fix captureHeaders middleware

* feat: migrate codewhisperer iam service to aws-sdk-v3 (#2284)

* refactor: remove aws-sdk v2 imports (#2290)

* fix: compile errors from merge conflicts (#2331)

* chore: bump runtimes to 0.3.0 (#2340)

* chore: bump runtimes to 0.3.0

* fix antlr4ng version conflict

* fix missing url polyfill

* chore: remove old ignore entries (#2350)

* chore: update versions

* chore: fix more dependencies

* fix: fallback to empty string in aws sdk v3 (#2414)

* chore: update indexing bundle(#2417)

This reverts commit baf20b7.

---------

Co-authored-by: aws-toolkit-automation <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Co-authored-by: Tai Lai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants