ec2plugin: fallback to utf8 if response encoding not set (#278)

a-jackson · web-flow · commit c285b7ddc96f · 2023-01-03T11:54:26.000-08:00
fixes #277
diff --git a/sdk/src/Core/Plugins/EC2Plugin.cs b/sdk/src/Core/Plugins/EC2Plugin.cs
@@ -142,7 +142,9 @@ protected virtual string DoRequest(string url, HttpMethod method, Dictionary<str
                     throw new Exception("Unable to complete the request successfully");
                 }
 
-                var encoding = Encoding.GetEncoding(response.ContentEncoding);
+                var encoding = !string.IsNullOrEmpty(response.ContentEncoding)
+                    ? Encoding.GetEncoding(response.ContentEncoding)
+                    : Encoding.UTF8;
 
                 using (var streamReader = new StreamReader(response.GetResponseStream(), encoding))
                 {

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,9 @@ protected virtual string DoRequest(string url, HttpMethod method, Dictionary<str`
`142`	`142`	`throw new Exception("Unable to complete the request successfully");`
`143`	`143`	`}`
`144`	`144`
`145`		`- var encoding = Encoding.GetEncoding(response.ContentEncoding);`
	`145`	`+ var encoding = !string.IsNullOrEmpty(response.ContentEncoding)`
	`146`	`+ ? Encoding.GetEncoding(response.ContentEncoding)`
	`147`	`+ : Encoding.UTF8;`
`146`	`148`
`147`	`149`	`using (var streamReader = new StreamReader(response.GetResponseStream(), encoding))`
`148`	`150`	`{`